-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] CI: dot files and add xmlsec1 apt package #109
Conversation
The apt package is required to install auth_saml, dependency of auth_saml_environment.
01356ef
to
de10347
Compare
.travis.yml
Outdated
@@ -12,6 +12,7 @@ addons: | |||
apt: | |||
packages: | |||
- expect-dev # provides unbuffer utility | |||
- "xmlsec1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you get rid of travis here if you have time? 🙏 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add apt dependencies on github actions? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allright, it's done!
This PR seems to solve one issue, but there's another one in runboat
Seems related to Full traceback
|
created a specific issue for runboat |
It seems
xmlsec1
is an apt requirement forauth_saml
module: https://github.com/OCA/server-auth/blob/667f2e597fe883d4335da589cf8148aa525100be/auth_saml/__manifest__.py#L15-L17It is hosted on https://github.com/OCA/server-auth, but we're installing it here because it's a dependency of
auth_saml_environment
.On
server-auth
, we have this: https://github.com/OCA/server-auth/blob/667f2e597fe883d4335da589cf8148aa525100be/.travis.yml#L15NB: Testing to see if it fixes the issue