Skip to content

Commit

Permalink
Merge pull request #1542 from sunflowerit/8.0-logging_json-dont-bork-…
Browse files Browse the repository at this point in the history
…on-missing-package

[FIX] logging_json ImportError
  • Loading branch information
pedrobaeza committed Apr 3, 2019
2 parents eacac19 + 2835e11 commit 4e22ed0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions logging_json/json_log.py
Expand Up @@ -17,9 +17,9 @@
_logger = logging.getLogger(__name__)

try:
from pythonjsonlogger import jsonlogger
from pythonjsonlogger.jsonlogger import JsonFormatter, RESERVED_ATTRS
except ImportError:
jsonlogger = None # noqa
JsonFormatter = object
_logger.debug("Cannot 'import pythonjsonlogger'.")


Expand Down Expand Up @@ -55,7 +55,7 @@ def is_true(strval):
}


class OdooJsonFormatter(jsonlogger.JsonFormatter):
class OdooJsonFormatter(JsonFormatter):

def add_fields(self, log_record, record, message_dict):
record.pid = os.getpid()
Expand All @@ -80,9 +80,9 @@ class OdooJsonDevFormatter(ColoredFormatter):
def format(self, record):
response = super(OdooJsonDevFormatter, self).format(record)
extra = {}
RESERVED_ATTRS = list(jsonlogger.RESERVED_ATTRS) + ["dbname", "pid"]
reserved_attrs = list(RESERVED_ATTRS) + ["dbname", "pid"]
for key, value in record.__dict__.items():
if (key not in RESERVED_ATTRS and not
if (key not in reserved_attrs and not
(hasattr(key, "startswith") and key.startswith('_'))):
extra[key] = value
if extra:
Expand Down

0 comments on commit 4e22ed0

Please sign in to comment.