Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig server environment #1051

Closed
wants to merge 69 commits into from

Conversation

Projects
None yet
@TDu
Copy link
Member

commented Nov 13, 2017

No description provided.

@Yajo Yajo added the needs fixing label Nov 14, 2017

@Yajo Yajo added this to the 11.0 milestone Nov 14, 2017

@pedrobaeza pedrobaeza referenced this pull request Nov 15, 2017

Open

Migration to version 11.0 #1008

52 of 92 tasks complete
@TDu

This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2017

Travis is green 😃
But code coverage is complaining about 'Missing base report'
Anyone knows how to fix this ?

jgrandguillaume and others added some commits Oct 12, 2011

[ADD] server evironment file + sample
(lp:c2c-addons/6.1  rev 11)
[FIX] typo
(lp:c2c-addons/6.1  rev 28.1.1)
[MRG] from upstream
(lp:c2c-addons/6.1  rev 45.1.4)
[FIX] drop the hack for the GTK client, because for 6.1 the web clien…
…t is the blessed target.

(lp:c2c-addons/6.1  rev 40.2.1)
[MRG] Fix by florent.x on server_environment: drop the hack for the G…
…TK client, because for 6.1 the web client is the blessed target.

(lp:c2c-addons/6.1  rev 116)
capture stderr as well as stdout when diagnosing
This fixes #125 because in some Ubuntu systems
lsb_release outputs to stderr as well as stdout. This message will be
printed to console, not logged nor shown among server infomation. That
way the message is lost and only pollutes unit tests output.

oca-transbot and others added some commits Jun 24, 2017

Remove encoding declaration from XML view
It's no longer supported in lxml:

      File "/opt/odoo/external-src/server-tools/server_environment/serv_config.py", line 228, in _build_osv
        cls._arch = etree.fromstring(arch)
      File "src/lxml/lxml.etree.pyx", line 3213, in lxml.etree.fromstring (src/lxml/lxml.etree.c:82934)
      File "src/lxml/parser.pxi", line 1814, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:124471)
    ValueError: Unicode strings with encoding declaration are not supported. Please use bytes input or XML fragments without declaration.
Add OCA as author of OCA addons
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.

@TDu TDu force-pushed the TDu:11.0-mig-server_environment branch from b46bd92 to 86646af Nov 21, 2017

@grindtildeath
Copy link

left a comment

Works well 👍

@TDu

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2017

Code coverage is fixed, thanks invisible hand.
Last commit fixes a bug when displaying the view from Settings > Technical > Server Environment

@guewen guewen added needs review and removed needs fixing labels Nov 28, 2017

@guewen

guewen approved these changes Nov 28, 2017

@simahawk
Copy link
Contributor

left a comment

LGTM, just a not on copy headers.

@@ -0,0 +1,20 @@
##############################################################################

This comment has been minimized.

Copy link
@simahawk

simahawk Nov 29, 2017

Contributor

shouldn't we remove these headers from init.py and shorten the other ones?

@yvaucher

This comment has been minimized.

Copy link
Member

commented Nov 29, 2017

As stated here https://docs.google.com/spreadsheets/d/1Xg95cW4TFMf_Lo5i_CZC_qOOfN8RgxPRc0LJTLTkdUI/edit?usp=sharing

could we create a project for server-environement modules ?

OCA/server-env for

mail_environment
server_environment
server_environment_files_sample
server_environment_ir_config_parameter

@simahawk

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2018

replaced by OCA/server-env#4

Please, close this one

@TDu TDu closed this Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.