Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig server environment #1051

Closed
wants to merge 69 commits into from
Closed

Conversation

TDu
Copy link
Member

@TDu TDu commented Nov 13, 2017

No description provided.

@yajo yajo added this to the 11.0 milestone Nov 14, 2017
@pedrobaeza pedrobaeza mentioned this pull request Nov 15, 2017
92 tasks
@TDu
Copy link
Member Author

TDu commented Nov 17, 2017

Travis is green 😃
But code coverage is complaining about 'Missing base report'
Anyone knows how to fix this ?

jgrandguillaume and others added 25 commits November 21, 2017 15:40
(lp:c2c-addons/6.1  rev 11)
(lp:c2c-addons/6.1  rev 28.1.1)
…t is the blessed target.

(lp:c2c-addons/6.1  rev 40.2.1)
(lp:c2c-addons/6.1  rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target.

(lp:c2c-addons/6.1  rev 116)
This fixes OCA#125 because in some Ubuntu systems
lsb_release outputs to stderr as well as stdout. This message will be
printed to console, not logged nor shown among server infomation. That
way the message is lost and only pollutes unit tests output.
oca-transbot and others added 19 commits November 21, 2017 15:40
It's no longer supported in lxml:

      File "/opt/odoo/external-src/server-tools/server_environment/serv_config.py", line 228, in _build_osv
        cls._arch = etree.fromstring(arch)
      File "src/lxml/lxml.etree.pyx", line 3213, in lxml.etree.fromstring (src/lxml/lxml.etree.c:82934)
      File "src/lxml/parser.pxi", line 1814, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:124471)
    ValueError: Unicode strings with encoding declaration are not supported. Please use bytes input or XML fragments without declaration.
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@TDu TDu force-pushed the 11.0-mig-server_environment branch from b46bd92 to 86646af Compare November 21, 2017 14:43
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@TDu
Copy link
Member Author

TDu commented Nov 23, 2017

Code coverage is fixed, thanks invisible hand.
Last commit fixes a bug when displaying the view from Settings > Technical > Server Environment

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a not on copy headers.

@@ -0,0 +1,20 @@
##############################################################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we remove these headers from init.py and shorten the other ones?

@yvaucher
Copy link
Member

As stated here https://docs.google.com/spreadsheets/d/1Xg95cW4TFMf_Lo5i_CZC_qOOfN8RgxPRc0LJTLTkdUI/edit?usp=sharing

could we create a project for server-environement modules ?

OCA/server-env for

mail_environment
server_environment
server_environment_files_sample
server_environment_ir_config_parameter

@simahawk
Copy link
Contributor

replaced by OCA/server-env#4

Please, close this one

@TDu TDu closed this Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet