[8.0][FIX] auth ldap populate #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would rearchive users which had been unarchive in the first place on the way: * use sets to remove duplicates * don't query all ldap configurations if one has said the user must be archived * improve the view by not relying on a string attribute
gurneyalex
force-pushed
the
8.0-fix_auth_ldap_populate
branch
from
a25bb01
to
9022a9a
Compare
CharlineDumontet
approved these changes
Feb 22, 2019
guewen
approved these changes
Feb 25, 2019
yajo
added a commit
to Tecnativa/server-tools
that referenced
this pull request
Mar 22, 2019
The variable is a dict, and the desired value must be accessed via key, not attribute. This fixes a bug introduced in OCA#1519.
|
This broke the branch. See fix in #1531. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1518 to 8.0