-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12 add base substate #1695
12 add base substate #1695
Conversation
a48f536
to
1dfb17a
Compare
Hi @bealdav, @pedrobaeza , @hparfr , @rvalyi, |
Hi, @jgrandguillaume, @gurneyalex, @kittiu |
_order = 'name asc, model asc' | ||
|
||
# Data in this object should be created by import as technical data | ||
# in specific module ex : sale_subsatate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/subastate/substate
model = fields.Selection(selection=[], string='Apply on', required=True) | ||
target_state_field = fields.Char( | ||
required=True, help='Technical target state field name.' | ||
' Ex fore sale order "state" for other "status" ... ') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/fore/for
string='Target State Value', | ||
ondelete='restrict') | ||
active = fields.Boolean(default=True) | ||
mail_template_id = fields.Many2one( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's seams not generic for me to put a dependency on mail here
Hello @mourad-ehm, I've goot a question: did you consider compatbility with Acsone state machine https://github.com/acsone/scobidoo I feel like it's a nice way to manage sub-states so I want to make sure you are aware of this module. How is your substate module better or complementary to Scobidoo? |
@mourad-ehm I think this is interesting concept. |
Hi @rvalyi, I did not know this module. But when I reviewed de code I think that most goal of scobidoo module is to add workflow management (replace the old openerp workflow) and accessoritly manage sub states. base_substate module is a very simple to configure and use (no need to define a yaml spec of workflow). But it not cover a workflow management. |
Hi @kittiu, |
@mourad-ehm may be just a GUESS, but as I tested around, I found the problem is with the test of
Seem like, the @post_install(True) (just guess), make it run after every module in the repo is installed. And while database_cleanup is cleaning the table, i.e., I am not sure how to fix it too. Sorry... May be, moving your module out of this server-tools will already fix it? :) |
thanks @kittiu. |
This module provide an abstract models to manage customizable
substates to be applied on different models (sale order, purchase, ...).
It is not useful for itself. You can see an example of implementation
in the 'sale_substate' module. (sale-workflow repository).
Applied to sale
OCA/sale-workflow#955