[12.0][MIG] base_custom_info: Migration to 12.0 #1721
Conversation
Tardo
force-pushed
the
12.0-mig-base_custom_info
branch
from
6e04d46
to
dd17df9
Compare
|
Are you planning on finishing this? Do you need help? |
|
Yes, we need to check a problem with the onchanges. I'll check this week. |
Okay, thanks! |
pedrobaeza
force-pushed
the
12.0-mig-base_custom_info
branch
from
dd17df9
to
5f7110b
Compare
pedrobaeza
changed the title
|
This should be now reviewable. @Tardo I think you can squash a bit commits. |
Tardo
force-pushed
the
12.0-mig-base_custom_info
branch
from
5f7110b
to
8268bdc
Compare
|
Hey @Tardo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Tardo
force-pushed
the
12.0-mig-base_custom_info
branch
from
8268bdc
to
238092d
Compare
Mostly no changes from 8.0 after all.
# Conflicts: # base_custom_info/__manifest__.py
* Now you can define properties types, and access rules are inherited from the model/record linked to the custom info record. * Simplified version of computed value. * Implement for res.partner. * Add tests and fix bugs discovered in the meantime. * Allow to disable partner custom info tab, and custom info menu. * All of it can be set within general settings. * Now, by default, this module does not display custom info for partners unless in demo mode. Better fit for a base module. * You can disable the top menu entry too if it disturbs you, or enable it for everybody. * Give a special form when editing in partner custom info tab. * Sortable properties. * Sort values at onchange time. * Improve performance in onchange. * Split in several model files.
…the write We must avoid to rely on the order in which computed fields (including related fields) and constrains methods are applied. Due to a recent change into the ORM, the contrains on the model_id into CustomInfoTemplate is now called AFTER the recompute of the related model field into property_ids.info_value_ids As side effect, when the constrains is called, the model on the info value is already updated with the new value and we no more know the old value....
Tardo
force-pushed
the
12.0-mig-base_custom_info
branch
from
ef63556
to
c75c14f
Compare
|
Ready for review |
|
@AdriaGForgeFlow can you review? |
base_custom_info/README.rst
Outdated
|
|
||
| The *value* will always be one of these. | ||
|
|
||
| Recursive templates using options |
There was a problem hiding this comment.
Is this feature enabled? I don't seem to find how to use it.
There was a problem hiding this comment.
I think that this refers to the feature of mix properties of different templates for a selection.
There was a problem hiding this comment.
Yes, but how do you use it? How do you specify in a selection property that links to a different template?
When I follow the instructions in the README and select "Needs videogames" in the Smart Partners template, nothing happens, no new properties appear in the list to be filled. Even though I see this in the property form view:
See:
There was a problem hiding this comment.
Finally, it's an outdated readme... moved to roadmap. This feature it's not implemented yet. Thanks!
Tardo
force-pushed
the
12.0-mig-base_custom_info
branch
from
c75c14f
to
70581d7
Compare
|
Change done! thanks for the review |
- Put force_save=1 for allowing the web client to send readonly values to server - Switch widget="selection" to "many2one" default with options because it's not supported anymore in tree view - Move value_id to parent view.
Tardo
force-pushed
the
12.0-mig-base_custom_info
branch
from
70581d7
to
153e1d0
Compare
|
Let's merge it then! /ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 3997e28. Thanks a lot for contributing to OCA. ❤️ |
Cc @Tecnativa TT18593