[15][MIG] Migrate auto_backup #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anhvu-sg , do yo know how this modules differs from? https://apps.odoo.com/apps/modules/15.0/auto_backup/ |
manuelcalerosolis
approved these changes
Mar 24, 2022
anhvu-sg
force-pushed
the
15.0-mig-auto-backup
branch
2 times, most recently
from
4a81b31
to
8bf701f
Compare
done @flachica |
flachica
approved these changes
Mar 24, 2022
|
@anhvu-sg you must add history of commits to this PR. |
Added all the new fields and sentences. This will be the template for translations.
Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
- Follow template README. - Remove HTML README. - Move models to models folder. - Model and view file names follow guidelines. - Unused methods cleanup. - Remove unneeded `.pot` file. - Fix permissons. - Follow PEP8 in names everywhere. - Set more descriptive field names. - Disable backups for other databases, for security. - Remove db name from generated file, for easier cleanup. - EAFP logic everywhere. - More descriptive name. - Data files moved to YAML, with cleaner ir.cron record creation. - Add permissions for db.backup model. - Icons. - Update tests with new format. - Storage method is a selectable, for easier extensibility. - Instead of custom mailing, it just has a mail thread where you can subscribe. - Should fix almost all comments in OCA#203. - Reduce headers. This respects the upstream license choice (GPL/AGPL) but reduces verbosity. It would be ideal to have everything under AGPL though.
Bump module version to 8.0.1.0.1
* Add self.ensure_ones * Add test coverage
* [10.0][auto_backup] Menu entry moved * Update version in manifest
Currently translated at 58.2% (32 of 55 strings) Translation: server-tools-11.0/server-tools-11.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/
Currently translated at 80.2% (69 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 89.5% (77 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 94.1% (81 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 9.3% (8 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/ca/
Currently translated at 100.0% (86 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/es_AR/
Currently translated at 94.1% (81 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 50.0% (43 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/hr/
anhvu-sg
force-pushed
the
15.0-mig-auto-backup
branch
2 times, most recently
from
5d09af4
to
03a9ba2
Compare
|
hi @cubells , thanks for your support. The history have been updated |
|
This PR has the |
|
thanks @anhvu-sg Now you can solve conflicts by rebasing |
|
Hey @anhvu-sg, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
anhvu-sg
force-pushed
the
15.0-mig-auto-backup
branch
from
0a4a8f3
to
60193a5
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7befb85. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module had been installed and used on my V15 project.