[MIG] html_text: Migration to 15.0 #2256
Conversation
* [8.0][html_text] Excerpt generator. This module adds a technical utility to allow the developer to get an excerpt from any HTML chunk. You can choose the maximum amount of words or characters if you want. See the README and inline docstrings for further details.
OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex
[FIX] Tests [FIX] Do not test the specific exception [FIX] Do not test the specific exception
Currently translated at 100.0% (1 of 1 strings) Translation: server-tools-12.0/server-tools-12.0-html_text Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-html_text/zh_CN/
Currently translated at 100.0% (1 of 1 strings) Translation: server-tools-12.0/server-tools-12.0-html_text Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-html_text/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-13.0/server-tools-13.0-html_text Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-html_text/
Currently translated at 100.0% (1 of 1 strings) Translation: server-tools-13.0/server-tools-13.0-html_text Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-html_text/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-html_text Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-html_text/
|
/ocabot migration html_text |
|
Sorry @gaikaz you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
Sad... Had to try 😛 |
|
I'm sorry @gaikaz! Maybe we can open up this function for non-maintainers. /ocabot migration html_text |
|
It was done on purpose. Check comments about this on OCA/oca-github-bot#97 (comment) |
|
It's ok. Maybe some day... 😄 |
|
You can apply for being a PSC if your efforts concentrate in one specific area: http://odoo-community.org/page/psc |
|
@pedrobaeza thanks for the pointer. I understand the considerations, but it makes me feel sad, as I was hoping that the OCA bot would allow the OCA to grant more powers to incidental contributors in a flexible and controlled way. |
|
If you think this can be used without a abuse on some way, please comment. Ideas welcome. |
|
@pedrobaeza no new ideas, I just think opening up the feature to all contributors might be worth a little damage but I'm well aware that it's people like you who have to clean it up afterwards so I'll leave it at this. |
|
We can detect if CIs are green (with exceptions), no other PR is already proposed for the module, and then let any contributor to mark it, but it's a very hard work to do on the bot side, and the performance may be drained with this, and this is also not good enough, as a previous migration may not be still marked by anyone. I think we should focus more on recruiting more PSCs to perform this easy task than to sophisticate the bot in this way. |
|
I personally would gladly help tagging PRs that I come across with the Side-question: How does OCA feel about people from the same company approving their own PRs on OCA? |
|
Hi @gaikaz. Your command failed:
Ocabot commands
More information
|
|
Right now, there's no mechanism on ocabot to add some trusted logins/orgs: all works through GitHub permissions. That can be a way to enlarge the maintainers of this part, but not sure the technical difficulties for implementing it. About the reviews from the same organization, it's not something incorrect, while they are real, not only approvals for circumvent the review guidelines. We do continuously in my organization for being self-dependent in all of our contributions. I think it's very easy to detect fake reviews most of the times. There's still the requirement of one of the reviews being from a trusted reviewer/PSC, or at least the merge being triggered by a PSC/maintainer, so that keep the situation controlled. |
|
@OCA/tools-maintainers |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-2256-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Hmm... Looks like it failed by some Github cache thing. |
|
@gaikaz indeed! /ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6ec1356. Thanks a lot for contributing to OCA. ❤️ |
Standard migration to version
15.0.