[FIX] users_ldap_populate: Protect ldap library import

[pedrobaeza]

To avoid errors on dependent builds

[sbidoul]

_logger.warning instead of debug

[pedrobaeza]

Being discussed in https://github.com/OCA/account-financial-tools/pull/281/files#r37519322

[moylop260]

👍

[moylop260]

If fine to me
But if you add external depends is better: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#__openerp__py

[pedrobaeza]

As this module depends of auth_ldap, and that module already has that external_dependencies defined, is not explicitly needed.

[nhomar]

👍

[nhomar]

@pedrobaeza the problem of expect the external_dependency only in the parent module, when you click on "install" the screen will retreive an error mentioning the dependency, not the module itself, IMHO it is useful here, even if technically it is not necesary, but BTW you have my +1 we have a rule to follow, and the rule do not mention explicitally how manage the depednency itself.

[moylop260]

@pedrobaeza
Ok, I got it
Thanks for explanation
confirmed 👍

[lmignon]

@pedrobaeza once a module do an explicit import of an external dependency you must declare the dependency into the manifest. It's required to avoid that if the decency is removed from the dependent module the current one will be broken.

[moylop260]

@lmignon
You are right.
However, IMHO you should create a PR to add this case in https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#__openerp__py
And later we will need to fix all repo's

IMHO By this case the main goal is done!

[lmignon]

@moylop260 the rule is explicit.

If your module use extras dependencies of python or binaries you should add to __openerp__py file the section external_dependencies.

from ldap.filter import filter_format

The import means that this module use an extra dependency.

[pedrobaeza]

As stated before in others PRs "Better explicit than implicit", so I have added the external_dependencies in the manifest.

[nhomar]

comments applied, then +1 valid, I merge.