[14.0][FIX] *: remove lxml from python depends
#2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisg123v
force-pushed
the
14.0-rm_lxml-luisg
branch
2 times, most recently
from
0a71a1c
to
249891a
Compare
Such dependency is already included in Odoo requirements using a pinned version [1]. Adding here could cause to upgrade the library to an incompatible version. [1] https://github.com/odoo/odoo/blob/54e58b3e47ee/requirements.txt#L23
Such dependency is already included in Odoo requirements using a pinned version [1]. Adding here could cause to upgrade the library to an incompatible version. [1] https://github.com/odoo/odoo/blob/54e58b3e47ee/requirements.txt#L23
luisg123v
changed the title
lxml from dependslxml from python depends
luisg123v
force-pushed
the
14.0-rm_lxml-luisg
branch
from
249891a
to
9704d72
Compare
|
Hi @moylop260, Could you review, please? |
|
Hi @pedrobaeza, what do you think about this one? |
pedrobaeza
changed the title
lxml from python dependslxml from python depends
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at e12761b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such dependency is already included in Odoo requirements using a pinned
version [1]. Adding here could cause to upgrade the library to an
incompatible version.
[1] https://github.com/odoo/odoo/blob/54e58b3e47ee/requirements.txt#L23