[16.0][MIG] attachment_delete_restrict: Migration to 16.0 #2673

AungKoKoLin1997 · 2023-07-07T06:28:38Z

This PR encompasses the following steps:

Standard Migration
Fixes
- Removal of the display of duplicate allowed user names.
- Correct the many2many field relation
- Correction of domain values and addition of the many2many_tags widget in views.
Improvements
- Addition of _onchange_restrict_delete_attachment() to clear groups and users when restrict_delete_attachment is not set to custom or owner_custom.

yostashiro

@AungKoKoLin1997 I think some of the changes should be in separate commits to be backported to 14.0.

yostashiro · 2023-07-11T00:29:05Z

attachment_delete_restrict/models/ir_attachment.py

@@ -33,7 +33,7 @@ def _raise_delete_attachment_error(self, allowed_users):
                "You are not allowed to delete this attachment.\n\nUsers with "
                "the delete permission:\n%s"
            )
-            % ("\n".join(allowed_users.mapped("name")) or "None")
+            % ("\n".join(list(set(allowed_users.mapped("name")))) or "None")


This set() should be done when allowed_users is updated in _check_custom_delete_attachment() instead. It should perhaps be in a separate commit to be backported.

yostashiro · 2023-07-11T00:35:24Z

attachment_delete_restrict/models/ir_model.py

+    )
+
+    @api.onchange("restrict_delete_attachment")
+    def _clear_groups_users(self):


Suggested change

def _clear_groups_users(self):

def _onchange_restrict_delete_attachment(self):

I suppose this should also be in a separate commit to be backported.

yostashiro · 2023-07-11T00:53:10Z

attachment_delete_restrict/models/res_groups.py

+        "the models "
+        "assigned here.",


Suggested change

"the models "

"assigned here.",

"the models assigned here. Restrict Attachment Deletion must be 'Custom' or 'Owner + Custom' for the model to be selected here.",

yostashiro · 2023-07-11T00:54:35Z

attachment_delete_restrict/models/res_groups.py

+    def write(self, vals):
+        res = super(ResGroups, self).write(vals)
+        if "delete_attachment_model_ids" in vals:
+            for group in self:
+                for model in group.delete_attachment_model_ids:
+                    if group not in model.delete_attachment_group_ids:
+                        model.write(
+                            {
+                                "delete_attachment_group_ids": [(4, group.id)],
+                            }
+                        )
+        return res


Can you explain why this should be needed?

yostashiro · 2023-07-11T00:55:45Z

attachment_delete_restrict/models/res_users.py

+    def write(self, vals):
+        res = super(ResUsers, self).write(vals)
+        if "delete_attachment_model_ids" in vals:
+            for user in self:
+                for model in user.delete_attachment_model_ids:
+                    if user not in model.delete_attachment_user_ids:
+                        model.write(
+                            {
+                                "delete_attachment_user_ids": [(4, user.id)],
+                            }
+                        )
+        return res


Why do we need this?

yostashiro · 2023-07-11T02:58:26Z

attachment_delete_restrict/models/ir_attachment.py

        if self.env.user not in allowed_users:
            return self._raise_delete_attachment_error(allowed_users)

    def unlink(self):
        res_models = list(set(self.filtered("res_model").mapped("res_model")))
        if res_models:
-            models = self.env["ir.model"].search([("model", "in", res_models)])
+            models = self.env["ir.model"].sudo().search([("model", "in", res_models)])


This should be part of the migration, due to the ACL change in 16.0 (or 15.0, I haven't checked).

…aming

Currently translated at 100.0% (37 of 37 strings) Translation: server-tools-14.0/server-tools-14.0-attachment_delete_restrict Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-attachment_delete_restrict/es_AR/

- Remove the display of duplicate allowed user names. - Correct the many2many field relation - Correct domain values and add the many2many_tags widget in views.

legalsylvain · 2023-12-20T23:35:11Z

hi @yostashiro. Thanks for your review. could you update it ?
thanks !

AungKoKoLin1997 · 2024-03-06T07:22:09Z

@OCA-server-tools-maintainers
Is it possible to review this PR?

yostashiro

Code review and functional test. LGTM.

kanda999

Code and Function : LGTM

kanda999 · 2024-05-29T08:13:53Z

@AungKoKoLin1997
Could you rebase this PR to restart runboat?

- Add _onchange_restrict_delete_attachment() to clear groups and users when restrict_delete_attachment is not set to custom or owner_custom.

OCA-git-bot · 2024-06-12T07:33:55Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

yostashiro suggested changes Jul 11, 2023

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-mig-attachment_delete_restrict branch from 3840945 to 2fdfe5f Compare July 11, 2023 02:55

yostashiro reviewed Jul 11, 2023

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-mig-attachment_delete_restrict branch from 2fdfe5f to ca37da1 Compare July 11, 2023 04:32

yostashiro and others added 15 commits November 1, 2023 14:22

[ADD] attachment_delete_restrict

b759b68

[IMP] attachment_delete_restrict: black, isort, prettier

7d2c4ed

[MIG] attachment_delete_restrict: Migration to 14.0

ded6fa2

rework module attachment_delete_restrict (to squash after review)

fc9d547

attachment_delete_restrict: refactor test and improve restrict mode n…

825868c

…aming

attachment_delete_restrict: refactor code

7c2e23a

[UPD] Update attachment_delete_restrict.pot

ff9ebcc

[UPD] README.rst

853b211

[ADD] icon.png

8b7800c

Added translation using Weblate (Spanish (Argentina))

990823e

[FIX] attachment_delete_restrict: adapt to Odoo permission change

3b58a43

attachment_delete_restrict 14.0.1.0.1

633f04e

[MIG] attachment_delete_restrict: Migration to 16.0

0707cca

[FIX] attachment_delete_restrict

3c6802d

- Remove the display of duplicate allowed user names. - Correct the many2many field relation - Correct domain values and add the many2many_tags widget in views.

AungKoKoLin1997 force-pushed the 16.0-mig-attachment_delete_restrict branch from ca37da1 to f0c88d3 Compare November 1, 2023 07:52

AungKoKoLin1997 force-pushed the 16.0-mig-attachment_delete_restrict branch from f0c88d3 to 434dc12 Compare January 30, 2024 03:50

yostashiro approved these changes Mar 7, 2024

View reviewed changes

kanda999 approved these changes May 29, 2024

View reviewed changes

OCA-git-bot added the approved label May 29, 2024

[IMP] attachment_delete_restrict

dfd3a27

- Add _onchange_restrict_delete_attachment() to clear groups and users when restrict_delete_attachment is not set to custom or owner_custom.

AungKoKoLin1997 force-pushed the 16.0-mig-attachment_delete_restrict branch from 434dc12 to dfd3a27 Compare May 30, 2024 02:51

OCA-git-bot added the ready to merge label Jun 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] attachment_delete_restrict: Migration to 16.0 #2673

[16.0][MIG] attachment_delete_restrict: Migration to 16.0 #2673

AungKoKoLin1997 commented Jul 7, 2023 •

edited

Loading

yostashiro left a comment

yostashiro Jul 11, 2023

yostashiro Jul 11, 2023

yostashiro Jul 11, 2023

yostashiro Jul 11, 2023

yostashiro Jul 11, 2023

yostashiro Jul 11, 2023

legalsylvain commented Dec 20, 2023

AungKoKoLin1997 commented Mar 6, 2024

yostashiro left a comment

kanda999 left a comment

kanda999 commented May 29, 2024

OCA-git-bot commented Jun 12, 2024

	def _clear_groups_users(self):
	def _onchange_restrict_delete_attachment(self):

	"the models "
	"assigned here.",
	"the models assigned here. Restrict Attachment Deletion must be 'Custom' or 'Owner + Custom' for the model to be selected here.",

[16.0][MIG] attachment_delete_restrict: Migration to 16.0 #2673

Are you sure you want to change the base?

[16.0][MIG] attachment_delete_restrict: Migration to 16.0 #2673

Conversation

AungKoKoLin1997 commented Jul 7, 2023 • edited Loading

yostashiro left a comment

Choose a reason for hiding this comment

yostashiro Jul 11, 2023

Choose a reason for hiding this comment

yostashiro Jul 11, 2023

Choose a reason for hiding this comment

yostashiro Jul 11, 2023

Choose a reason for hiding this comment

yostashiro Jul 11, 2023

Choose a reason for hiding this comment

yostashiro Jul 11, 2023

Choose a reason for hiding this comment

yostashiro Jul 11, 2023

Choose a reason for hiding this comment

legalsylvain commented Dec 20, 2023

AungKoKoLin1997 commented Mar 6, 2024

yostashiro left a comment

Choose a reason for hiding this comment

kanda999 left a comment

Choose a reason for hiding this comment

kanda999 commented May 29, 2024

OCA-git-bot commented Jun 12, 2024

AungKoKoLin1997 commented Jul 7, 2023 •

edited

Loading