-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.0 base external dbsource #513
Conversation
Needs a rebase on upstream 9.0 |
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/128/9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naousse https://runbot.odoo-community.org/runbot/149/9.0
for server-tools
dbname='template1' user='dbuser' host='localhost' port='5432' \ | ||
password=%s | ||
- SQLite: sqlite:///test.db | ||
""") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naousse Can you add this help
string as the placeholder as well?
Otherwise 👍
@naousse Please add |
It doesn't work. |
@naousse Let's put |
@@ -19,6 +19,4 @@ | |||
# | |||
############################################################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch to newer shortened header - https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py#L3
Thanks for the submission @naousse - few comments inline. Additionally- would you mind increasing the test coverage a bit? |
👍 |
@lasley Can you give us some time to review/merge here? Thank you. I hope to see you in Belgium soon. |
Will review today. Just got my ticket & lodging for Belgium - will be seeing you there @max3903 😄 |
Woot ❤️ @naousse thanks for cutting the test gap cut in half like that. LGTM 👍 |
@naousse - before I merge would you mind squashing please and thanks 😄 |
@lasley Github allows you to merge or to squash and merge at the same time ;) |
No description provided.