Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Typo in font name #764

Closed
wants to merge 2 commits into from
Closed

[FIX] Typo in font name #764

wants to merge 2 commits into from

Conversation

ateijelo
Copy link
Contributor

@ateijelo ateijelo commented Mar 7, 2017

No description provided.

@ateijelo ateijelo closed this Mar 7, 2017
@ateijelo ateijelo deleted the 9.0 branch March 7, 2017 19:52
@lasley
Copy link
Contributor

lasley commented Mar 7, 2017

@ateijelo - are you planning on re-submitting from a different fork or something? This looks to have been a perfectly valid fix IMO

@ateijelo
Copy link
Contributor Author

ateijelo commented Mar 7, 2017

Yes, I mean to resubmit it. But I just realized after hastily creating it that some of the changes were inside msgid's. So I panicked :) and decided to go back and review this more carefully.

@ateijelo
Copy link
Contributor Author

ateijelo commented Mar 7, 2017

By the way, I don't know where else to ask this, but I believe the msgids inside the .po files should be kept "id-like". And then one should have the long unwieldy blocks of text in the msgstr of each language.

@ateijelo
Copy link
Contributor Author

ateijelo commented Mar 7, 2017

I apologize for this mess :) I created a new PR: #765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants