Skip to content

Commit

Permalink
[FIX] date_range: Disable external dependency check
Browse files Browse the repository at this point in the history
Pylint-odoo is not able to detect properly whitelisted odoo's dependencies if an isort configuration file is present into the directory. Therefore the check fails by complaining that the dateutil dependecy is not declared into the manifest. A fix could have been to declare the dependency into the manifest . Unfortunately, in this case, a warning will be issued by runbot complaining that the python external dependency dateutil should be replaced by it's PyPI package name. Unfortunalely, if we put the Pypi package name into the external dependencies, pylint fails again since it's not able to play with PyPI distribution names.
The workaround is to temporarily disable this check into pylint. I every case, all the pre-commit files will be reset once pylint will be fixed
  • Loading branch information
lmignon committed Oct 18, 2019
1 parent 8390483 commit 5ca40cd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions .pylintrc-mandatory
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ enable=anomalous-backslash-in-string,
method-inverse,
method-required-super,
method-search,
missing-import-error,
missing-manifest-dependency,
missing-import-error,
openerp-exception-warning,
pointless-statement,
pointless-string-statement,
Expand Down
1 change: 0 additions & 1 deletion date_range/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,4 @@
"qweb": ["static/src/xml/date_range.xml"],
"development_status": "Mature",
"maintainers": ["lmignon"],
"external_dependencies": {"python": ["dateutil"]},
}

0 comments on commit 5ca40cd

Please sign in to comment.