Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][FIX] date_range: fix constrains + fix onchange #26

Merged
merged 1 commit into from
Nov 19, 2018
Merged

[11.0][FIX] date_range: fix constrains + fix onchange #26

merged 1 commit into from
Nov 19, 2018

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 2, 2018

This PR is the backport of #25 including the following:

  • fix date_range_type constrains
  • fix date_range onchange
  • add missing _description
  • javascript eslint warnings
  • minor fixes in readme files

@astirpe astirpe mentioned this pull request Oct 2, 2018
Merged
lmignon
lmignon approved these changes Oct 2, 2018
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!! Thank you for the backport @astirpe

@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 4, 2018
@astirpe
Copy link
Member Author

astirpe commented Oct 17, 2018

Can this one be merged?

@lmignon lmignon merged commit 79bed09 into OCA:11.0 Nov 19, 2018
@astirpe astirpe deleted the 11_fix_date_range branch November 19, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astirpe @lmignon @pedrobaeza