[11.0] [MIG] base_import_security_group #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 tasks
This module makes importing data from CSV files optional for each user, allowing it only for those users belonging to a specific group. [FIX] Solved flake8 error E305: expected 2 blank lines after class or function definition, found 1 [FIX] Renamed base_import_csv_optional in base_import_security_group [FIX] Solved flake8 error E501: line too long; [FIX] Removed unnecessary monkeypatch and extended Base.load method; [FIX] Bugfixing in Base.load method; [FIX] Code refactoring [IMP] Tests created
[FIX] Updated travis postgresql version [FIX] Updated phantom_js version in travis [FIX] Configured travis to run tests for this module in isolation mode [FIX] Configured travis to run tests for this module in isolation mode [FIX] Added group to demo_user for test purposes [FIX] Changed waiting condition on Phantom JS test [FIX] Removed Travis configuration for isolated test environment [FIX] Changed waiting condition in phantom_js test [FIX] Changed target action in phantom_js test [FIX] Changed target action in phantom_js test
i-vyshnevska
force-pushed
the
11.0-mig-base_import_security_group
branch
from
b41c4c9
to
e6f6829
Compare
|
@i-vyshnevska ping? |
i-vyshnevska
changed the title
i-vyshnevska
force-pushed
the
11.0-mig-base_import_security_group
branch
from
f922c3f
to
f46ec7d
Compare
i-vyshnevska
force-pushed
the
11.0-mig-base_import_security_group
branch
from
4f8fe5b
to
ad9e8b0
Compare
|
@astirpe thanks for review, updated |
astirpe
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Code review OK.
Would be nice to fix some non-blocking warnings in travis, they are regarding javascript:
base_import_security_group/static/src/js/import.js:4: [W7903(javascript-lint), ] 'KanbanController' is assigned a value but never used. [Error/no-unused-vars]
base_import_security_group/static/src/js/import.js:6: [W7903(javascript-lint), ] 'ListController' is assigned a value but never used. [Error/no-unused-vars]
base_import_security_group/static/src/js/import.js:12: [W7903(javascript-lint), ] Expected indentation of 8 spaces but found 4. [Error/indent]
base_import_security_group/static/src/js/import.js:12: [W7903(javascript-lint), ] 'viewInfo' is defined but never used. [Error/no-unused-vars]
base_import_security_group/static/src/js/import.js:12: [W7903(javascript-lint), ] 'params' is defined but never used. [Error/no-unused-vars]
base_import_security_group/static/src/js/import.js:14: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
base_import_security_group/static/src/js/import.js:14: [W7903(javascript-lint), ] Missing semicolon. [Error/semi]
base_import_security_group/static/src/js/import.js:15: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
base_import_security_group/static/src/js/import.js:15: [W7903(javascript-lint), ] 'result' is assigned a value but never used. [Error/no-unused-vars]
base_import_security_group/static/src/js/import.js:16: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
base_import_security_group/static/src/js/import.js:18: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
base_import_security_group/static/src/js/import.js:18: [W7903(javascript-lint), ] 'result' is already declared in the upper scope. [Error/no-shadow]
base_import_security_group/static/src/js/import.js:18: [W7903(javascript-lint), ] Missing space before opening brace. [Error/space-before-blocks]
base_import_security_group/static/src/js/import.js:19: [W7903(javascript-lint), ] Expected indentation of 16 spaces but found 12. [Error/indent]
base_import_security_group/static/src/js/import.js:19: [W7903(javascript-lint), ] Missing semicolon. [Error/semi]
base_import_security_group/static/src/js/import.js:20: [W7903(javascript-lint), ] Expected indentation of 16 spaces but found 12. [Error/indent]
base_import_security_group/static/src/js/import.js:20: [W7903(javascript-lint), ] Missing space before opening brace. [Error/space-before-blocks]
base_import_security_group/static/src/js/import.js:21: [W7903(javascript-lint), ] Expected indentation of 20 spaces but found 16. [Error/indent]
base_import_security_group/static/src/js/import.js:21: [W7903(javascript-lint), ] Multiple spaces found before 'true'. [Error/no-multi-spaces]
base_import_security_group/static/src/js/import.js:22: [W7903(javascript-lint), ] Expected indentation of 16 spaces but found 12. [Error/indent]
base_import_security_group/static/src/js/import.js:23: [W7903(javascript-lint), ] Expected indentation of 16 spaces but found 12. [Error/indent]
base_import_security_group/static/src/js/import.js:30: [W7903(javascript-lint), ] Expected indentation of 8 spaces but found 4. [Error/indent]
base_import_security_group/static/src/js/import.js:31: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
base_import_security_group/static/src/js/import.js:32: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
base_import_security_group/static/src/js/import.js:37: [W7903(javascript-lint), ] Expected indentation of 8 spaces but found 4. [Error/indent]
base_import_security_group/static/src/js/import.js:38: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
base_import_security_group/static/src/js/import.js:39: [W7903(javascript-lint), ] Expected indentation of 12 spaces but found 8. [Error/indent]
|
This PR has the |
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Sep 27, 2019
|
Congratulations, your PR was merged at dbe597b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate module base_import_security_group