[MIG] base_tier_validation_formula: Migrate to version 17.0 #799

sonhd91 · 2024-01-10T05:40:17Z

Ref: BSRD-706

Depended on:

[17.0][MIG] base_tier_validation: Migration to 17.0 #787

bosd

Thanks for this pr! Looks good, Some non-blocking comments.

bosd · 2024-01-10T06:27:59Z

base_tier_validation_formula/__manifest__.py

+    "name": "Base Tier Validation Formula",
+    "summary": """
+        Formulas for Base tier validation""",
+    "version": "17.0.1.0.0",


Suggested change

"version": "17.0.1.0.0",

"version": "17.0.1.0.0",

"category": "Tools",

bosd · 2024-01-10T06:30:08Z

base_tier_validation_formula/__manifest__.py

+    "summary": """
+        Formulas for Base tier validation""",
+    "version": "17.0.1.0.0",
+    "license": "AGPL-3",


Suggested change

"license": "AGPL-3",

"license": "AGPL-3",

"development_status": "Mature",

Promotion should'nt have to be in migration commit. But I noticed the missing tag, and it likely satisfies mature status.

bosd · 2024-01-10T06:33:30Z

base_tier_validation_formula/tests/test_tier_validation.py

+            }
+        )
+
+        # Create users:


Is there a reason new users are created here?
(It comes at a cost, can the users from the base module be re-used?)

Yeah, that will do, but we still need create one more user for tests case

fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu

Currently translated at 100.0% (17 of 17 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation_formula/es/

Currently translated at 100.0% (17 of 17 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation_formula/zh_CN/

[UPD] Update base_tier_validation_formula.pot

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-13.0/server-ux-13.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation_formula/

… in tier definitions [UPD] Update base_tier_validation_formula.pot

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-13.0/server-ux-13.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation_formula/

Currently translated at 100.0% (15 of 15 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation_formula/zh_CN/ Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (15 of 15 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation_formula/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-13.0/server-ux-13.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation_formula/

Currently translated at 80.0% (12 of 15 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation_formula/it/

[UPD] Update base_tier_validation_formula.pot

Currently translated at 100.0% (15 of 15 strings) Translation: server-ux-14.0/server-ux-14.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation_formula/es/

… records

[UPD] Update base_tier_validation_formula.pot

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_formula/

Currently translated at 80.0% (12 of 15 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_formula/it/

- Include context keys for avoiding mail operations overhead.

sonhd91 · 2024-01-10T08:45:27Z

Branch updated, please check again

Since base_tier_validation was merged, I uncomment some related code for this module

gurneyalex · 2024-01-25T16:17:29Z

/ocabot merge nobump

OCA-git-bot · 2024-01-25T16:17:37Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-799-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-25T16:21:26Z

Congratulations, your PR was merged at 782d799. Thanks a lot for contributing to OCA. ❤️

sonhd91 force-pushed the 17.0-mig-base_tier_validation_formula branch from 0539c98 to 39c4544 Compare January 10, 2024 05:43

bosd reviewed Jan 10, 2024

View reviewed changes

AdriaGForgeFlow and others added 28 commits January 10, 2024 14:39

[IMP] base_tier_validation: Pass parameters as functions

26b723e

[12.0][MIG] base_tier_validation_formula

cfd3972

Added translation using Weblate (Spanish)

daf3c90

Translated using Weblate (Spanish)

3632ed4

Currently translated at 100.0% (17 of 17 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation_formula/es/

[FIX] ceci n'est pas une URL

b517891

Added translation using Weblate (Chinese (Simplified))

1b0d515

[IMP] base_tier_validation_formula: black, isort

4f52d2f

[MIG] 13.0 base_tier_validation_formula

5a01896

[UPD] Update base_tier_validation_formula.pot

[IMP] base_tier_validation_formula: Allow use both domain and formula…

eccfc10

… in tier definitions [UPD] Update base_tier_validation_formula.pot

base_tier_validation_formula 13.0.1.1.0

dce2431

[12.0][fix] base_tier_validation_formula: Add default

9f69eff

base_tier_validation_formula 13.0.1.1.1

443109c

pre-commit update

5e70d7e

Added translation using Weblate (Italian)

d19beeb

Translated using Weblate (Italian)

ccb46b9

Currently translated at 80.0% (12 of 15 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation_formula/it/

[IMP] : black, isort, prettier

3b86afd

[14.0][MIG] base_tier_validation_formula

c7d78c9

[UPD] Update base_tier_validation_formula.pot

[IMP] base_tier_validation_formula: Improve tests

987158d

base_tier_validation_formula 14.0.2.0.0

d8228c4

Translated using Weblate (Spanish)

e852484

Currently translated at 100.0% (15 of 15 strings) Translation: server-ux-14.0/server-ux-14.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation_formula/es/

[FIX] base_tier_validation_formula: Fix cache miss error on iteration…

85d23bd

… records

base_tier_validation_formula 14.0.2.0.1

23ef89a

JasminSForgeFlow and others added 10 commits January 10, 2024 14:39

[MIG] base_tier_validation_formula: Migration to 15.0

8bb81ef

[UPD] Update base_tier_validation_formula.pot

[16.0][MIG] base_tier_validation_formula: Migration to 16.0

f68ae34

Translated using Weblate (Italian)

ac62fc4

Currently translated at 80.0% (12 of 15 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_formula/it/

[IMP] base_tier_validation_formula: update tests to support messages

8aa7089

[BOT] post-merge updates

04d8710

[IMP] base_tier_validation_formula: test performance improvement

0b83be4

- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates

6fd9849

[IMP] base_tier_validation_formula: pre-commit auto fixes

416b31b

sonhd91 force-pushed the 17.0-mig-base_tier_validation_formula branch from 39c4544 to 2c86da9 Compare January 10, 2024 08:44

[MIG] base_tier_validation_formula: Migrate to version 17.0

c2499af

sonhd91 force-pushed the 17.0-mig-base_tier_validation_formula branch from 2c86da9 to c2499af Compare January 10, 2024 08:47

sonhd91 mentioned this pull request Jan 10, 2024

Migration to version 17.0 #752

Open

22 tasks

gurneyalex added this to the 17.0 milestone Jan 12, 2024

gurneyalex approved these changes Jan 12, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 25, 2024

OCA-git-bot merged commit 4947f97 into OCA:17.0 Jan 25, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] base_tier_validation_formula: Migrate to version 17.0 #799

[MIG] base_tier_validation_formula: Migrate to version 17.0 #799

sonhd91 commented Jan 10, 2024 •

edited

bosd left a comment

bosd Jan 10, 2024

bosd Jan 10, 2024

bosd Jan 10, 2024

bosd Jan 10, 2024

sonhd91 Jan 10, 2024 •

edited

sonhd91 commented Jan 10, 2024 •

edited

gurneyalex commented Jan 25, 2024

OCA-git-bot commented Jan 25, 2024

OCA-git-bot commented Jan 25, 2024

	"version": "17.0.1.0.0",
	"version": "17.0.1.0.0",
	"category": "Tools",

	"license": "AGPL-3",
	"license": "AGPL-3",
	"development_status": "Mature",

[MIG] base_tier_validation_formula: Migrate to version 17.0 #799

[MIG] base_tier_validation_formula: Migrate to version 17.0 #799

Conversation

sonhd91 commented Jan 10, 2024 • edited

bosd left a comment

Choose a reason for hiding this comment

bosd Jan 10, 2024

Choose a reason for hiding this comment

bosd Jan 10, 2024

Choose a reason for hiding this comment

bosd Jan 10, 2024

Choose a reason for hiding this comment

bosd Jan 10, 2024

Choose a reason for hiding this comment

sonhd91 Jan 10, 2024 • edited

Choose a reason for hiding this comment

sonhd91 commented Jan 10, 2024 • edited

gurneyalex commented Jan 25, 2024

OCA-git-bot commented Jan 25, 2024

OCA-git-bot commented Jan 25, 2024

sonhd91 commented Jan 10, 2024 •

edited

sonhd91 Jan 10, 2024 •

edited

sonhd91 commented Jan 10, 2024 •

edited