Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] multi_step_wizard #83

Closed

Conversation

alexey-pelykh
Copy link
Contributor

@alexey-pelykh
Copy link
Contributor Author

@guewen if possible, please review.

multi_step_wizard/__manifest__.py Outdated Show resolved Hide resolved
The final state has no related method because the view
should only display a button to close the wizard.

Look at the models and views of task.link.jira and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a link to the other repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think that example in USAGE is enough?

multi_step_wizard/readme/CONTRIBUTORS.rst Show resolved Hide resolved
@alexey-pelykh alexey-pelykh force-pushed the 12.0-mig-multi_step_wizard branch 4 times, most recently from 1a88fa8 to c89b82d Compare July 22, 2019 19:03
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 12.0-ocabot-merge-pr-83-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 23, 2019
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 77b4476. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@alexey-pelykh alexey-pelykh deleted the 12.0-mig-multi_step_wizard branch July 23, 2019 07:33
@guewen
Copy link
Member

guewen commented Aug 6, 2019

Thanks for moving the module here @alexey-pelykh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants