[11.0] [BUG] Fix date range type unlink. #9
Conversation
feketemihai
force-pushed
the
11.0-fix-unlink_date_tange_type
branch
2 times, most recently
from
aa2df69
to
3c88efa
Compare
date_range/models/date_range_type.py
Outdated
| @@ -26,3 +26,10 @@ def _default_company(self): | |||
| _sql_constraints = [ | |||
| ('date_range_type_uniq', 'unique (name,company_id)', | |||
| 'A date range type must be unique per company !')] | |||
|
|
|||
| @api.multi | |||
| def unlink(self): | |||
There was a problem hiding this comment.
Instead of this, use ondelete='restrict' in the many2one in date.range.
There was a problem hiding this comment.
@pedrobaeza I know, but i wanted to track the exact error, and to benefit from it to super method in OCA/account-financial-tools#636, because there the super was not covered in tests, red build, and i only had an postgres integrity error, and wanted to track it as odoo error..
There was a problem hiding this comment.
You can test it the same. Just use:
with self.assertRaises(Exception):
with self.env.cr.savepoint():
self.date_range_type.unlink()There was a problem hiding this comment.
@pedrobaeza Updated, but i think is fine if i leave also the unlink method, to have a nice error message for the user.
There was a problem hiding this comment.
But this is code to maintain. Generic error is clear enough IMO.
feketemihai
force-pushed
the
11.0-fix-unlink_date_tange_type
branch
6 times, most recently
from
e3c356f
to
449a5fb
Compare
|
It would be convenient to split in 2 commits: one for the unlink problem, and another for pylint warnings, coding removal, etc. |
|
I will do it later. Thanks for review. |
feketemihai
force-pushed
the
11.0-fix-unlink_date_tange_type
branch
from
449a5fb
to
e4c6beb
Compare
|
🍏 |
|
Thanks |
No description provided.