13.0 mig base technical features #96

jimhoefnagels · 2019-09-30T12:23:51Z

No description provided.

LoisRForgeFlow

Tested on runbot, preference not available:

base_technical_features/models/res_users.py

base_technical_features/models/ir_ui_menu.py

base_technical_features/models/base.py

Tonow-c2c · 2019-10-11T13:36:50Z

@jimhoefnagels one tip on github to help to do only one commit with code suggestion is :

go to Files changed
on suggestion you click to 'add suggestion to batch`
change the commit message
https://help.github.com/en/articles/incorporating-feedback-in-your-pull-request

Tonow-c2c

Just code review

base_technical_features/models/res_users.py

emagdalenaC2i · 2019-10-16T12:36:08Z

@jimhoefnagels I think you have to rebase and run pre-commit run -a otherwise, ocabot merge will fail.

emagdalenaC2i · 2019-10-16T12:36:48Z

See https://odoo-community.org/blog/the-oca-blog-1/post/black-isort-pre-commit-97

CasVissers-360ERP

Functional test. LGTM

pedrobaeza · 2019-10-17T12:45:39Z

Please check Travis

emagdalenaC2i · 2019-10-30T10:10:59Z

@jimhoefnagels to fix Travis you must run the pre-commit

Tonow-c2c · 2019-10-30T13:06:59Z

@jimhoefnagels to fix Travis you must run the pre-commit

link https://github.com/OCA/l10n-brazil/wiki/Pre-commit-hook

And may be someone with enough right can add this in English on all OCA repos wiki
Or a link to one readme section in https://github.com/OCA/maintainer-tools
@pedrobaeza @guewen ?

to help I start with that OCA/maintainer-tools#434

pedrobaeza · 2019-10-30T19:01:15Z

There's an explanation at https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0 and https://odoo-community.org/blog/the-oca-blog-1/post/black-isort-pre-commit-97. It may be added to contribution guidelines, but I think we are perverting what a guideline is with procedures.

oca-clabot · 2019-11-04T08:23:29Z

Hey @jimhoefnagels, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Fekete Mihai mihai.fekete@forbiom.eu (no github login found)

Appreciation of efforts,
OCA CLAbot

emagdalenaC2i

LGTM

base_technical_features/models/res_users.py

emagdalenaC2i · 2019-11-18T02:54:31Z

@pedrobaeza All comments were solved. @mreficent and @lreficent Please, could you update your review?

pedrobaeza · 2019-11-18T09:02:17Z

Please squash you migration commits into one.

AaronHForgeFlow · 2019-11-26T12:29:38Z

base_technical_features/data/res_users.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo noupdate="1">
+    <record model="res.users" id="base.user_root">


IMHO this should be user_admin instead of root user.

pedrobaeza · 2019-11-27T13:20:29Z

Please include #110

HviorForgeFlow · 2019-12-17T13:06:27Z

ping @jimhoefnagels

AdriaGForgeFlow · 2020-01-03T15:50:54Z

@jimhoefnagels Are you going to finish this?

AaronHForgeFlow

👍 LGTM

AdriaGForgeFlow · 2020-01-09T08:31:33Z

Could you rebase and fix commit history?

LoisRForgeFlow · 2020-01-13T10:27:52Z

Hi @jimhoefnagels

The history is still incorrect. Have you followed the migration guide (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0)? If you need some help please ask for it.

LoisRForgeFlow

Until history is fixed this can not be merged IMO.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/zh_CN/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt_BR/

Currently translated at 87.5% (7 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

LoisRForgeFlow

LGTM now, thanks

MiquelRForgeFlow

LGTM

OCA-git-bot · 2020-01-29T09:17:45Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

jimhoefnagels · 2020-02-12T13:02:55Z

Hi @OCA/tools-maintainers, can this PR be merged?

LoisRForgeFlow · 2020-02-14T14:42:48Z

/ocabot merge

OCA-git-bot · 2020-02-14T14:43:11Z

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-96-by-LoisRForgeFlow-bump-no, awaiting test results.

Signed-off-by LoisRForgeFlow

OCA-git-bot · 2020-02-14T14:58:51Z

Congratulations, your PR was merged at e9015e2. Thanks a lot for contributing to OCA. ❤️

LoisRForgeFlow requested changes Sep 30, 2019

View reviewed changes

jimhoefnagels force-pushed the 13.0-mig-base_technical_features branch from d35d045 to 37f68cb Compare September 30, 2019 15:41

pedrobaeza added this to the 13.0 milestone Oct 1, 2019

OCA-git-bot mentioned this pull request Oct 1, 2019

Migration to version 13.0 #93

Closed

12 tasks

MiquelRForgeFlow reviewed Oct 1, 2019

View reviewed changes

base_technical_features/models/res_users.py Outdated Show resolved Hide resolved

base_technical_features/models/res_users.py Outdated Show resolved Hide resolved

base_technical_features/models/res_users.py Outdated Show resolved Hide resolved

jimhoefnagels force-pushed the 13.0-mig-base_technical_features branch from 90bdb46 to 6300090 Compare October 2, 2019 08:26

Tonow-c2c reviewed Oct 10, 2019

View reviewed changes

base_technical_features/models/res_users.py Outdated Show resolved Hide resolved

base_technical_features/models/ir_ui_menu.py Outdated Show resolved Hide resolved

base_technical_features/models/base.py Outdated Show resolved Hide resolved

Tonow-c2c approved these changes Oct 11, 2019

View reviewed changes

emagdalenaC2i reviewed Oct 11, 2019

View reviewed changes

base_technical_features/models/res_users.py Outdated Show resolved Hide resolved

CasVissers-360ERP approved these changes Oct 17, 2019

View reviewed changes

emagdalenaC2i approved these changes Nov 4, 2019

View reviewed changes

base_technical_features/models/res_users.py Show resolved Hide resolved

AaronHForgeFlow suggested changes Nov 26, 2019

View reviewed changes

AaronHForgeFlow approved these changes Jan 7, 2020

View reviewed changes

jimhoefnagels force-pushed the 13.0-mig-base_technical_features branch from 5eece81 to b6ba0aa Compare January 10, 2020 15:28

LoisRForgeFlow requested changes Jan 13, 2020

View reviewed changes

oca-transbot and others added 11 commits January 13, 2020 14:16

Update translation files

a8dbd14

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Translated using Weblate (Italian)

2b2d2f7

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/

Translated using Weblate (Portuguese)

ed3af60

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt/

[UPD] README.rst

d036412

Translated using Weblate (Chinese (Simplified))

9f5f37d

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/zh_CN/

Translated using Weblate (Portuguese (Brazil))

318f612

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt_BR/

Translated using Weblate (Croatian)

16323cd

Currently translated at 87.5% (7 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

[IMP]base_tchnical_features. Assign automatically to admin not to root

c1115b3

base_technical_features 12.0.1.1.0

eea1585

Translated using Weblate (Croatian)

43f9ace

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

[IMP] base_technical_features: black, isort

c99d77a

jimhoefnagels force-pushed the 13.0-mig-base_technical_features branch 2 times, most recently from 539383a to d628b5a Compare January 13, 2020 13:54

LoisRForgeFlow approved these changes Jan 15, 2020

View reviewed changes

OCA-git-bot added the approved label Jan 15, 2020

jimhoefnagels force-pushed the 13.0-mig-base_technical_features branch 2 times, most recently from 57771ac to afbc90c Compare January 22, 2020 11:08

[MIG] base_technical_features: Migration to 13.0

8922da1

jimhoefnagels force-pushed the 13.0-mig-base_technical_features branch from afbc90c to 8922da1 Compare January 22, 2020 11:45

[IMP] solve pre commit warnings

0ef2582

MiquelRForgeFlow approved these changes Jan 29, 2020

View reviewed changes

OCA-git-bot added the ready to merge label Jan 29, 2020

OCA-git-bot added a commit that referenced this pull request Feb 14, 2020

Merge PR #96 into 13.0

cfde7b5

Signed-off-by LoisRForgeFlow

OCA-git-bot merged commit 0ef2582 into OCA:13.0 Feb 14, 2020

OCA-git-bot added the merged 🎉 label Feb 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

13.0 mig base technical features #96

13.0 mig base technical features #96

jimhoefnagels commented Sep 30, 2019

LoisRForgeFlow left a comment

Tonow-c2c commented Oct 11, 2019

Tonow-c2c left a comment

emagdalenaC2i commented Oct 16, 2019

emagdalenaC2i commented Oct 16, 2019

CasVissers-360ERP left a comment

pedrobaeza commented Oct 17, 2019

emagdalenaC2i commented Oct 30, 2019

Tonow-c2c commented Oct 30, 2019 •

edited

Loading

pedrobaeza commented Oct 30, 2019

oca-clabot commented Nov 4, 2019

emagdalenaC2i left a comment

emagdalenaC2i commented Nov 18, 2019

pedrobaeza commented Nov 18, 2019

AaronHForgeFlow Nov 26, 2019

pedrobaeza commented Nov 27, 2019

HviorForgeFlow commented Dec 17, 2019

AdriaGForgeFlow commented Jan 3, 2020

AaronHForgeFlow left a comment

AdriaGForgeFlow commented Jan 9, 2020

LoisRForgeFlow commented Jan 13, 2020

LoisRForgeFlow left a comment

LoisRForgeFlow left a comment

MiquelRForgeFlow left a comment

OCA-git-bot commented Jan 29, 2020

jimhoefnagels commented Feb 12, 2020

LoisRForgeFlow commented Feb 14, 2020

OCA-git-bot commented Feb 14, 2020

OCA-git-bot commented Feb 14, 2020

13.0 mig base technical features #96

13.0 mig base technical features #96

Conversation

jimhoefnagels commented Sep 30, 2019

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

Tonow-c2c commented Oct 11, 2019

Tonow-c2c left a comment

Choose a reason for hiding this comment

emagdalenaC2i commented Oct 16, 2019

emagdalenaC2i commented Oct 16, 2019

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 17, 2019

emagdalenaC2i commented Oct 30, 2019

Tonow-c2c commented Oct 30, 2019 • edited Loading

pedrobaeza commented Oct 30, 2019

oca-clabot commented Nov 4, 2019

emagdalenaC2i left a comment

Choose a reason for hiding this comment

emagdalenaC2i commented Nov 18, 2019

pedrobaeza commented Nov 18, 2019

AaronHForgeFlow Nov 26, 2019

Choose a reason for hiding this comment

pedrobaeza commented Nov 27, 2019

HviorForgeFlow commented Dec 17, 2019

AdriaGForgeFlow commented Jan 3, 2020

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

AdriaGForgeFlow commented Jan 9, 2020

LoisRForgeFlow commented Jan 13, 2020

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 29, 2020

jimhoefnagels commented Feb 12, 2020

LoisRForgeFlow commented Feb 14, 2020

OCA-git-bot commented Feb 14, 2020

OCA-git-bot commented Feb 14, 2020

Tonow-c2c commented Oct 30, 2019 •

edited

Loading