-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13.0 mig base technical features #96
13.0 mig base technical features #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d35d045
to
37f68cb
Compare
90bdb46
to
6300090
Compare
@jimhoefnagels one tip on github to help to do only one commit with code suggestion is :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just code review
@jimhoefnagels I think you have to rebase and run pre-commit run -a otherwise, ocabot merge will fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test. LGTM
Please check Travis |
@jimhoefnagels to fix Travis you must run the pre-commit |
link https://github.com/OCA/l10n-brazil/wiki/Pre-commit-hook And may be someone with enough right can add this in English on all OCA repos wiki to help I start with that OCA/maintainer-tools#434 |
There's an explanation at https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0 and https://odoo-community.org/blog/the-oca-blog-1/post/black-isort-pre-commit-97. It may be added to contribution guidelines, but I think we are perverting what a guideline is with procedures. |
Hey @jimhoefnagels, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pedrobaeza All comments were solved. @mreficent and @lreficent Please, could you update your review? |
Please squash you migration commits into one. |
@@ -0,0 +1,6 @@ | |||
<?xml version="1.0" encoding="utf-8" ?> | |||
<odoo noupdate="1"> | |||
<record model="res.users" id="base.user_root"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this should be user_admin instead of root user.
Please include #110 |
ping @jimhoefnagels |
@jimhoefnagels Are you going to finish this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Could you rebase and fix commit history? |
5eece81
to
b6ba0aa
Compare
The history is still incorrect. Have you followed the migration guide (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0)? If you need some help please ask for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until history is fixed this can not be merged IMO.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/
Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt/
Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/zh_CN/
Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt_BR/
Currently translated at 87.5% (7 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/
Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/
539383a
to
d628b5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks
57771ac
to
afbc90c
Compare
afbc90c
to
8922da1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
Hi @OCA/tools-maintainers, can this PR be merged? |
/ocabot merge |
On my way to merge this fine PR! |
Congratulations, your PR was merged at e9015e2. Thanks a lot for contributing to OCA. ❤️ |
No description provided.