[MIG] mail_tracking: Migrated to 10.0 #108
Conversation
| @api.depends('name', 'recipient') | ||
| def _compute_display_name(self): | ||
| def _comp_display_name(self): |
There was a problem hiding this comment.
I renamed this function since it triggered a warning that the field depended on itself.
The _compute_display_name function in models.py adds display_name as a dependency, so to avoid this warning I had to rename the function...
|
I have only done a basic form of testing (besides the python tests), which consists of sending e-mails to a mailcatcher and checking that the state "opened" and "read" are triggered. No idea how to actually test the spam states, etc. BTW, have you ever thought about adding a mailcatcher on your runbot? It makes it possible to see outgoing emails and it's quite useful at times. I use this quite a lot on our runbots, and it would make this module a teensy bit more easily testable. Anyway, just a passing remark :-) This module is quite nice & interesting btw! |
| @api.depends('name', 'recipient') | ||
| def _compute_display_name(self): | ||
| def _compute_tracking_display_name(self): |
There was a problem hiding this comment.
I renamed this function since it triggered a warning that the field depended on itself.
The _compute_display_name function in models.py adds _rec_name as a dependency, so to avoid this warning I had to rename the function...
My initial renaming didn't start with _compute; travis-bot didn't like that! Quite useful, we should consider adding it one day ourselves; would avoid new code with api.one's in it.
|
👍 |
|
@dbo-odoo - I like your idea of a mail catcher. Are you just using https://mailcatcher.me/ or similar? |
|
And cherry-pick also 60ea386? |
|
@pedrobaeza I've cherry-picked blindly for the moment; will have to check tests and runbot again... |
|
@pedrobaeza you're quite welcome :-) I've got some other pet projects at the moment but I keep the OCA repo in mind if I ever get some free time to dedicate to it! |
|
If you want me to take a look, just point me to the repo 😄 |
No description provided.