-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] mail_full_expand: Migrated to 10.0 #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code and functional review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dbo-odoo - minor comments inline
@@ -5,13 +5,13 @@ | |||
{ | |||
"name": "Mail full expand", | |||
"summary": "Expand mail in a big window", | |||
"version": "8.0.3.0.0", | |||
"version": "10.0.3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.0.1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you did not mean 10.0.1.0.01.1.1alpha+e
? 😛
<field name="notified_partner_ids" | ||
widget="many2many_tags" | ||
<odoo> | ||
<record id="view" model="ir.ui.view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend we switch this id to match OCA naming standards: mail_message_view_form
. Non-blocking
|
||
</data> | ||
</openerp> | ||
<record id="act_window" model="ir.actions.act_window"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend we switch this id to match OCA naming standards: mail_message_action
. Non-blocking
<record id="view" model="ir.ui.view"> | ||
<field name="name">mail.message.full_expand</field> | ||
<field name="model">mail.message</field> | ||
<field name="priority">30</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, otherwise the action on the "mail messages" menuitem in technical settings will load this view instead of the "standard" one (mail.view_message_form
) which has, for some unfathomable reason, a priority of 20 instead of the 16 default...
@dbo-odoo Are you going to work on this? |
I'm not dead :-) Sorry, I didn't have a lot of free time. I'll finish the current PRs when possible with a bit less productivity than last time :p |
hahaha, OK, good to see you around again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @dbo-odoo - looks like we have a CI 🔴 though 😦 https://travis-ci.org/OCA/social/jobs/178887566#L561
@lasley Up! :-) (like an idiot I applied your xmlid changes without grepping them first O_o) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @dbo-odoo
No description provided.