Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail_full_expand: Migrated to 10.0 #112

Merged
merged 1 commit into from
Nov 28, 2016
Merged

[IMP] mail_full_expand: Migrated to 10.0 #112

merged 1 commit into from
Nov 28, 2016

Conversation

bouvyd
Copy link
Contributor

@bouvyd bouvyd commented Oct 14, 2016

No description provided.

@bouvyd bouvyd changed the title [WIP] mail_full_expand: Migrated to 10.0 [IMP] mail_full_expand: Migrated to 10.0 Oct 14, 2016
@pedrobaeza pedrobaeza mentioned this pull request Oct 14, 2016
21 tasks
@lasley lasley added this to the 10.0 milestone Oct 14, 2016
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and functional review

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dbo-odoo - minor comments inline

@@ -5,13 +5,13 @@
{
"name": "Mail full expand",
"summary": "Expand mail in a big window",
"version": "8.0.3.0.0",
"version": "10.0.3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.0.1.0.0

Copy link
Contributor Author

@bouvyd bouvyd Nov 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you did not mean 10.0.1.0.01.1.1alpha+e? 😛

<field name="notified_partner_ids"
widget="many2many_tags"
<odoo>
<record id="view" model="ir.ui.view">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we switch this id to match OCA naming standards: mail_message_view_form. Non-blocking


</data>
</openerp>
<record id="act_window" model="ir.actions.act_window">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we switch this id to match OCA naming standards: mail_message_action. Non-blocking

<record id="view" model="ir.ui.view">
<field name="name">mail.message.full_expand</field>
<field name="model">mail.message</field>
<field name="priority">30</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise the action on the "mail messages" menuitem in technical settings will load this view instead of the "standard" one (mail.view_message_form) which has, for some unfathomable reason, a priority of 20 instead of the 16 default...

@pedrobaeza
Copy link
Member

@dbo-odoo Are you going to work on this?

@bouvyd
Copy link
Contributor Author

bouvyd commented Nov 25, 2016

@pedrobaeza
!not dead!

I'm not dead :-) Sorry, I didn't have a lot of free time. I'll finish the current PRs when possible with a bit less productivity than last time :p

@pedrobaeza
Copy link
Member

hahaha, OK, good to see you around again!

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @dbo-odoo - looks like we have a CI 🔴 though 😦 https://travis-ci.org/OCA/social/jobs/178887566#L561

@bouvyd
Copy link
Contributor Author

bouvyd commented Nov 28, 2016

@lasley Up! :-)

(like an idiot I applied your xmlid changes without grepping them first O_o)

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @dbo-odoo

@pedrobaeza pedrobaeza merged commit 9e2fbeb into OCA:10.0 Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants