Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 [mig] marketing_security_group #128

Merged
merged 3 commits into from
Nov 25, 2016

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Nov 10, 2016

Renaming module marketing_security_group to mass_mailing_security_group

cc @Tecnativa

@rafaelbn rafaelbn added this to the 9.0 milestone Nov 11, 2016
@rafaelbn
Copy link
Member

Hi @cubells ,

It doesn't work. For example, demo user cannot delete it's own mass mailings. Check image:

2016-11-11_18-38-01

Please review

Thanks!

@pedrobaeza
Copy link
Member

The branch is not correct. You have to check again your git-fu.

@cubells
Copy link
Sponsor Member Author

cubells commented Nov 12, 2016

@rafaelbn
this commit OCA/OCB@6375a4b changes the rules.

Now user can delete his own mass_mailing campaigns if belongs to Lead Automation user group, not to marketing group.

And it works.

yajo
yajo previously requested changes Nov 24, 2016
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming module marketing_security_group to mass_mailing_security_group

If you rename an addon, you need to write a migration script.


These 2 commits have the same message:

captura de pantalla de 2016-11-24 09-45-25

We need to have descriptive messages for commits, to know what you are doing in each of them and why. It only takes some seconds and you help all of us.


Your branch has conflicts:

captura de pantalla de 2016-11-24 09-45-35

Please do a rebase or merge and fix them.

Thanks 😉

@pedrobaeza
Copy link
Member

There's no need for a migration script, but a rename in the apriori.py file in OpenUpgrade, but he knows that and will make the PR when this one is merged.

@pedrobaeza
Copy link
Member

@cubells please check this.

@cubells cubells force-pushed the 9.0-mig-marketing_security_group branch 4 times, most recently from a56b5ca to ba3d3b6 Compare November 25, 2016 09:20
@cubells cubells force-pushed the 9.0-mig-marketing_security_group branch from ba3d3b6 to a359ec5 Compare November 25, 2016 09:22
@cubells
Copy link
Sponsor Member Author

cubells commented Nov 25, 2016

done.

@Tecnativa

oca-transbot and others added 2 commits November 25, 2016 19:59
 * Renaming module marketing_security_group to mass_mailing_security_group
 * Changes in README
 * Correct views
@pedrobaeza pedrobaeza force-pushed the 9.0-mig-marketing_security_group branch from e1b6aeb to 648e7b2 Compare November 25, 2016 18:59
@pedrobaeza pedrobaeza dismissed yajo’s stale review November 25, 2016 19:01

He's on holidays and his concerns have been attended

@pedrobaeza pedrobaeza merged commit c7dccc0 into OCA:9.0 Nov 25, 2016
@pedrobaeza pedrobaeza deleted the 9.0-mig-marketing_security_group branch November 25, 2016 19:25
@pedrobaeza pedrobaeza mentioned this pull request Nov 25, 2016
31 tasks
@pedrobaeza
Copy link
Member

Module renamed in OpenUpgrade in OCA/OpenUpgrade@544f656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants