Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][FIX][mail_tracking] Use event recipient address to find partners and contacts to bounce #133

Merged
merged 2 commits into from
Nov 25, 2016

Conversation

antespi
Copy link
Contributor

@antespi antespi commented Nov 24, 2016

There are use cases when Odoo send an email to a recipient (To:) and copy to others (Cc:). In these cases, events like bounces indicates the recipient address who is actually bounce. And sometimes it is not the original one (To:)

Current implementation:

  • Mark as bounce partners with original email recipient address (To:)

Desire implementation:

  • Mark as bounce the partner with the recipient address indicated in bounce event (if available)

This PR affects to mail_tracking and mail_tracking_mass_mailing addons

@antespi antespi added this to the 8.0 milestone Nov 24, 2016
if event_type in {'hard_bounce', 'spam', 'reject'}:
self.sudo()._partners_email_bounced_set(
event_type, event=event)
event_ids += event
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename variable to events

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little thing, but 👍

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@susport susport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza pedrobaeza merged commit 849df3c into OCA:8.0 Nov 25, 2016
@pedrobaeza pedrobaeza deleted the 8.0-fix_bounce_address branch November 25, 2016 18:03
antespi added a commit to Tecnativa/social that referenced this pull request Nov 28, 2016
pedrobaeza pushed a commit that referenced this pull request Nov 29, 2016
@rafaelbn
Copy link
Member

ping @carlosdauden

cubells pushed a commit to Tecnativa/social that referenced this pull request Jan 3, 2017
cubells pushed a commit to Tecnativa/social that referenced this pull request Jan 3, 2017
chienandalu pushed a commit to Tecnativa/social that referenced this pull request Mar 19, 2018
chienandalu pushed a commit to Tecnativa/social that referenced this pull request Apr 5, 2018
chienandalu pushed a commit to Tecnativa/social that referenced this pull request Apr 5, 2018
chienandalu pushed a commit to Tecnativa/social that referenced this pull request May 4, 2018
yajo pushed a commit that referenced this pull request May 7, 2018
ernestotejeda pushed a commit to Tecnativa/social that referenced this pull request Nov 5, 2018
ernestotejeda pushed a commit to Tecnativa/social that referenced this pull request Dec 18, 2018
alan196 pushed a commit to Jarsa/social that referenced this pull request Dec 22, 2018
ernestotejeda pushed a commit to Tecnativa/social that referenced this pull request Mar 7, 2019
Tardo pushed a commit to Tecnativa/social that referenced this pull request Nov 18, 2019
Tardo pushed a commit to Tecnativa/social that referenced this pull request Nov 18, 2019
Tardo pushed a commit to Tecnativa/social that referenced this pull request Dec 5, 2019
pedrobaeza pushed a commit to Tecnativa/social that referenced this pull request Jan 7, 2020
Tardo pushed a commit to Tecnativa/social that referenced this pull request Jan 27, 2020
Tardo pushed a commit to Tecnativa/social that referenced this pull request Feb 5, 2020
denris pushed a commit to denris/social that referenced this pull request Jan 28, 2021
SimoneVagile pushed a commit to SimoneVagile/social that referenced this pull request Jun 22, 2021
marco1esparza pushed a commit to marco1esparza/social that referenced this pull request Dec 1, 2021
JasminSForgeFlow pushed a commit to ForgeFlow/social that referenced this pull request Mar 25, 2022
JasminSForgeFlow pushed a commit to ForgeFlow/social that referenced this pull request Apr 20, 2022
maq-adhoc pushed a commit to adhoc-dev/social that referenced this pull request Dec 15, 2022
hvgollar pushed a commit to dynapps/social that referenced this pull request Dec 19, 2022
alan196 pushed a commit to Jarsa/social that referenced this pull request Feb 20, 2023
maq-adhoc pushed a commit to adhoc-dev/social that referenced this pull request Mar 6, 2023
mathieudelva pushed a commit to mathieudelva/social that referenced this pull request May 23, 2023
payen000 pushed a commit to vauxoo-dev/social that referenced this pull request Sep 5, 2023
payen000 pushed a commit to vauxoo-dev/social that referenced this pull request Sep 25, 2023
nguyenminhchien pushed a commit to nguyenminhchien/social that referenced this pull request Oct 20, 2023
trisdoan pushed a commit to trisdoan/social that referenced this pull request Mar 15, 2024
chienandalu pushed a commit to Tecnativa/social that referenced this pull request May 14, 2024
chienandalu pushed a commit to Tecnativa/social that referenced this pull request May 30, 2024
trisdoan pushed a commit to trisdoan/social that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants