-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] mail_debrand #1358
[17.0][MIG] mail_debrand #1358
Conversation
There's no commits preservation, as the module doesn't serve as is on v9.
without this fix, any regular notification (added as follower, thread notifications...) were not parsed at all and as a consequence also not debranded.
Currently translated at 40.0% (2 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/pt/
Currently translated at 100.0% (5 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/
Currently translated at 20.0% (1 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/nl/
Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/
Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/
@nguyenminhchien any interest in the changes I had in this PR guestisp#2 ? Either to include in this PR, or as a PR onto your branch by me, or I could wait for your PR to be merged and open my own pr ... ? |
Hi, i picked the commit related to the translation in v16.0. |
…l templates such as auth_signup's invitation email.
…ing was when using mail.mail_notification_light as a wrapper
Currently translated at 100.0% (3 of 3 strings) Translation: social-16.0/social-16.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_debrand/fr/
757cb4d
to
8c3bcb7
Compare
What is the status here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@novamilky The status is that we'd need another review. This could either be a code review, or a functional review. See https://odoo-community.org/resources/review. Would you like to give it a try? |
This PR has the |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
It looks like something changed on |
Congratulations, your PR was merged at f246716. Thanks a lot for contributing to OCA. ❤️ |
To replace #1257