Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mail_debrand #1358

Merged
merged 96 commits into from
May 6, 2024
Merged

Conversation

nguyenminhchien
Copy link
Contributor

@nguyenminhchien nguyenminhchien commented Apr 25, 2024

To replace #1257

pedrobaeza and others added 30 commits April 25, 2024 16:06
There's no commits preservation, as the module doesn't serve as is on v9.
without this fix, any regular notification (added as follower,
thread notifications...) were not parsed at all and as a
consequence also not debranded.
Currently translated at 40.0% (2 of 5 strings)

Translation: social-12.0/social-12.0-mail_debrand
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/pt/
Currently translated at 100.0% (5 of 5 strings)

Translation: social-12.0/social-12.0-mail_debrand
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-13.0/social-13.0-mail_debrand
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/
Currently translated at 20.0% (1 of 5 strings)

Translation: social-13.0/social-13.0-mail_debrand
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/nl/
Currently translated at 100.0% (5 of 5 strings)

Translation: social-13.0/social-13.0-mail_debrand
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/
Currently translated at 100.0% (5 of 5 strings)

Translation: social-13.0/social-13.0-mail_debrand
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/
@StefanRijnhart
Copy link
Member

Thanks! I think these migration commits by the author of the other PR can be squashed and named properly:
image

@paddlefish
Copy link

@nguyenminhchien any interest in the changes I had in this PR guestisp#2 ? Either to include in this PR, or as a PR onto your branch by me, or I could wait for your PR to be merged and open my own pr ... ?

@nguyenminhchien
Copy link
Contributor Author

@nguyenminhchien any interest in the changes I had in this PR guestisp#2 ? Either to include in this PR, or as a PR onto your branch by me, or I could wait for your PR to be merged and open my own pr ... ?

Hi, i picked the commit related to the translation in v16.0.
image

@nguyenminhchien
Copy link
Contributor Author

Thanks! I think these migration commits by the author of the other PR can be squashed and named properly: image

Hi, squashed.

@novamilky
Copy link

What is the status here?

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart StefanRijnhart mentioned this pull request May 3, 2024
30 tasks
@StefanRijnhart
Copy link
Member

@novamilky The status is that we'd need another review. This could either be a code review, or a functional review. See https://odoo-community.org/resources/review. Would you like to give it a try?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented May 6, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1358-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 6, 2024
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1358-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 44fceed into OCA:17.0 May 6, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f246716. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet