[9.0] [MIG] mass_mailing_unique module #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubells
force-pushed
the
9.0-mig-mass_mailing_unique
branch
2 times, most recently
from
7e60faf
to
016b5d2
Compare
yajo
approved these changes
Dec 13, 2016
| if errors: | ||
| raise ValidationError( | ||
| _("Fix this before installing:") + | ||
| "".join("\n" + e for e in errors)) |
There was a problem hiding this comment.
Could we test this hook (maybe with mock) to get 100% coverage?
|
Please add the said test and squash commits |
This new module avoids duplicates in mass mailing lists. Now you cannot have 2 lists with the same name, and you cannot have the same email repeated in a list. This will avoid sending the same mail to a contact repeated times, which will disturb him and most probably cause you to be blocked as spam.
pedrobaeza
force-pushed
the
9.0-mig-mass_mailing_unique
branch
from
1aa769e
to
2002c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa