Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] mail_tracking: bounces and others #1406

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

chienandalu
Copy link
Member

Some improvements/fixes detected in #1367 and brought to 16.0:

  • Add mail_tracking_ids to _compute_is_failed_message triggers.
  • Handle bounces to avoid flagging recipients which aren't bounced.
  • Add a logger.debug to research tracking issues
  • Make the links in the trackings respect the breadcrumb actions.

cc @Tecnativa

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 3, 2024
@pedrobaeza
Copy link
Member

Can you check CI?

Some improvements/fixes detected in OCA#1367 and brought to  `16.0`:

- Add `mail_tracking_ids` to `_compute_is_failed_message` triggers.
- Handle bounces to avoid flagging recipients which aren't bounced.
- Add a logger.debug to research tracking issues
- Make the links in the trackings respect the breadcrumb actions.
@chienandalu
Copy link
Member Author

Looks like the branch is red due to mail_composer_cc_bcc TestMailCcBcc.test_upstream_file_hash test

That module has the mail.mail._send method patched and that test is a way to check if the hash for the upstream method has changed, which has happened last week...: OCA/OCB@d492bbd

It's a good way to check if your patch is missing something... but it blocks everything else when it does...

So it would be needed to fix the patched method and set the new hash

cc @hailangvn2023 @sonhd91 @sonhd91 @nilshamerlinck @hbrunn

@nilshamerlinck
Copy link
Contributor

Hello @chienandalu thanks for the heads up! created #1407 and #1408 to do that

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-tracking this bugfix:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1406-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7d1a234 into OCA:16.0 Jul 8, 2024
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 72da77b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-imp-mail_tracking branch July 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants