[MIG] mass_mailing_partner: Migration to 10.0 #171

chienandalu · 2017-06-14T18:49:22Z

yajo

Please clean up commit history

pedrobaeza

Add your copyright in the files you touch and check Travis status. It should be green.

pedrobaeza · 2017-06-19T00:39:24Z

mass_mailing_partner/README.rst

+At first install, all existing mass mailing contacts are matched against
+partners. And also mass mailing statistics are matched using model and res_id.
+
+NOTE: When upgrading from version 1.0.0, no mass mailing statistics matching


This note can be removed and it doesn't apply anymore.

pedrobaeza · 2017-06-19T00:39:39Z

mass_mailing_partner/README.rst

+Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed feedback
+`here <https://github.com/OCA/crm/issues/new?body=module:%20mass_mailing_partner%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.


Remove this part according new README template

pedrobaeza · 2017-06-19T00:39:50Z

mass_mailing_partner/README.rst

+`here <https://github.com/OCA/crm/issues/new?body=module:%20mass_mailing_partner%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+
+License


Remove this unneeded section

pedrobaeza · 2017-06-19T00:40:20Z

mass_mailing_partner/__manifest__.py

+    "name": "Link partners with mass-mailing",
+    "version": "10.0.1.0.0",
+    "author": "Tecnativa, "
+              "Antiun Ingeniería S.L., "


Remove Antiun and Serv. Tecnol. ...

pedrobaeza · 2017-06-19T00:41:13Z

mass_mailing_partner/models/mail_mass_mailing_contact.py

+         _('Partner already exists in this mailing list.'))
+    ]
+
+    @api.one


Don't put @api.one here.

pedrobaeza · 2017-06-19T00:41:51Z

mass_mailing_partner/models/mail_mass_mailing_contact.py

+        vals = self._set_name_email(vals)
+        return super(MailMassMailingContact, self).create(vals)
+
+    @api.one


Rewrite the method to be @api.multi or this will hit performance.

pedrobaeza · 2017-06-19T00:42:27Z

mass_mailing_partner/models/res_partner.py

+                _("This partner '%s' is subscribed to one or more "
+                  "mailing lists. Email must be assigned." % self.name))
+
+    @api.one


Rewrite it for @api.multi

pedrobaeza · 2017-06-19T00:42:37Z

mass_mailing_partner/models/res_partner.py

+    def _compute_mass_mailing_contacts_count(self):
+        self.mass_mailing_contacts_count = len(self.mass_mailing_contact_ids)
+
+    @api.one


Make it @api.multi

pedrobaeza · 2017-06-20T16:37:42Z

mass_mailing_partner/models/res_partner.py

+    @api.multi
+    @api.depends('mass_mailing_stats')
+    def _compute_mass_mailing_stats_count(self):
+        self.mass_mailing_stats_count = len(self.mass_mailing_stats)


This needs a for loop

pedrobaeza · 2017-06-20T16:37:46Z

mass_mailing_partner/models/res_partner.py

+    @api.depends('mass_mailing_contact_ids',
+                 'mass_mailing_contact_ids.opt_out')
+    def _compute_mass_mailing_contacts_count(self):
+        self.mass_mailing_contacts_count = len(self.mass_mailing_contact_ids)


This needs a forloop

chienandalu · 2017-06-21T16:54:33Z

@pedrobaeza @yajo Changes done. Travis is failing on mail_tracking and mail_tracking_mailgun

yajo · 2017-06-22T07:22:33Z

mass_mailing_partner/i18n/mass_mailing_partner.pot

@@ -0,0 +1,140 @@
+# Translation of Odoo Server.


This file should not exist

yajo · 2017-06-22T07:24:25Z

mass_mailing_partner/models/res_partner.py

+        if self.mass_mailing_contact_ids and not self.email:
+            raise ValidationError(
+                _("This partner '%s' is subscribed to one or more "
+                  "mailing lists. Email must be assigned." % self.name))


The string modulo must be after the translation, not before.

@yajo I'm not sure about what you mean here 😕

yajo · 2017-06-22T07:26:14Z

mass_mailing_partner/wizard/partner_mail_list_wizard.xml

+            <footer>
+                <button string="Add contacts to mailing list" name="add_to_mail_list"
+                    type="object" class="oe_highlight"/>
+                or


Remove the or

chienandalu · 2017-06-26T08:51:54Z

@yajo @pedrobaeza Changes done

yajo

Code review

pedrobaeza · 2017-08-03T12:09:06Z

Please check errors

chienandalu · 2017-08-03T13:17:46Z

@pedrobaeza Errors seem to be unrelated. Rebasing to rebuild tests and see.

chienandalu · 2017-08-03T13:35:38Z

@pedrobaeza Well, this is runbot's log now 😕

Unable to find image 'oca-social:5c095f6_3' locally
docker: Error response from daemon: repository oca-social not found: does not exist or no pull access.
See 'docker run --help'.

pedrobaeza · 2017-08-03T13:38:23Z

Uhm, right, please try to fix main branch in other PR.

[IMP] mass_mailing_partner: Link mail statistics to partner

[FIX][mass_mailing_partner] Exclude opt_out. Now opted-out records will not be counted in the "Mailing lists" smart button in the partner form.

By indicating the exact `partner_id` and ensuring no contacts associated to it are found, you avoid possible duplication errors when several partners share the same name or email.

chienandalu · 2017-08-30T16:04:42Z

@pedrobaeza It's all green now

yajo added the needs review label Jun 15, 2017

yajo added this to the 10.0 milestone Jun 15, 2017

yajo requested changes Jun 15, 2017

View reviewed changes

chienandalu force-pushed the 10.0-mig-mass_mailing_partner branch 2 times, most recently from b691054 to 0c16dac Compare June 15, 2017 10:43

pedrobaeza requested changes Jun 19, 2017

View reviewed changes

pedrobaeza requested changes Jun 20, 2017

View reviewed changes

chienandalu force-pushed the 10.0-mig-mass_mailing_partner branch from fa6fa72 to 17da5df Compare June 21, 2017 14:41

yajo requested changes Jun 22, 2017

View reviewed changes

yajo approved these changes Jun 26, 2017

View reviewed changes

pedrobaeza mentioned this pull request Jul 17, 2017

Migration to version 10.0 #95

Closed

21 tasks

pedrobaeza approved these changes Aug 3, 2017

View reviewed changes

pedrobaeza force-pushed the 10.0-mig-mass_mailing_partner branch from e1bdf9b to 66a1ff2 Compare August 3, 2017 11:22

chienandalu force-pushed the 10.0-mig-mass_mailing_partner branch from 66a1ff2 to 5c095f6 Compare August 3, 2017 13:16

Javier Iniesta and others added 7 commits August 30, 2017 12:54

mass_mailing_partner

58c32a6

OCA Transbot updated translations from Transifex

f57547d

Link mail statistics to partner (OCA#104)

edefb60

[IMP] mass_mailing_partner: Link mail statistics to partner

OCA Transbot updated translations from Transifex

65e11ff

Exclude opt_out. (OCA#110)

6d5765e

[FIX][mass_mailing_partner] Exclude opt_out. Now opted-out records will not be counted in the "Mailing lists" smart button in the partner form.

Avoid duplicate error.

1e3f2f2

By indicating the exact `partner_id` and ensuring no contacts associated to it are found, you avoid possible duplication errors when several partners share the same name or email.

OCA Transbot updated translations from Transifex

b954dd4

chienandalu force-pushed the 10.0-mig-mass_mailing_partner branch 2 times, most recently from f364baf to 6a88a09 Compare August 30, 2017 13:55

[MIG] mass_mailing_partner: Migration to 10.0

2837986

pedrobaeza force-pushed the 10.0-mig-mass_mailing_partner branch from fe638e9 to 2837986 Compare August 30, 2017 17:02

pedrobaeza merged commit f80ac7a into OCA:10.0 Aug 30, 2017

pedrobaeza deleted the 10.0-mig-mass_mailing_partner branch August 30, 2017 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] mass_mailing_partner: Migration to 10.0 #171

[MIG] mass_mailing_partner: Migration to 10.0 #171

chienandalu commented Jun 14, 2017

yajo left a comment

pedrobaeza left a comment

pedrobaeza Jun 19, 2017

pedrobaeza Jun 19, 2017

pedrobaeza Jun 19, 2017

pedrobaeza Jun 19, 2017

pedrobaeza Jun 19, 2017

pedrobaeza Jun 19, 2017

pedrobaeza Jun 19, 2017

pedrobaeza Jun 19, 2017

pedrobaeza Jun 20, 2017

pedrobaeza Jun 20, 2017

chienandalu commented Jun 21, 2017

yajo Jun 22, 2017

yajo Jun 22, 2017

chienandalu Jun 22, 2017

yajo Jun 22, 2017

chienandalu commented Jun 26, 2017

yajo left a comment

pedrobaeza commented Aug 3, 2017

chienandalu commented Aug 3, 2017

chienandalu commented Aug 3, 2017

pedrobaeza commented Aug 3, 2017

chienandalu commented Aug 30, 2017

		`here <https://github.com/OCA/crm/issues/new?body=module:%20mass_mailing_partner%0Aversion:%208.0%0A%0ASteps%20to%20reproduce%0A-%20...%0A%0ACurrent%20behavior%0A%0AExpected%20behavior>`_.


		License

[MIG] mass_mailing_partner: Migration to 10.0 #171

[MIG] mass_mailing_partner: Migration to 10.0 #171

Conversation

chienandalu commented Jun 14, 2017

yajo left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu commented Jun 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu commented Jun 26, 2017

yajo left a comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 3, 2017

chienandalu commented Aug 3, 2017

chienandalu commented Aug 3, 2017

pedrobaeza commented Aug 3, 2017

chienandalu commented Aug 30, 2017