[ADD] mass_mailing_resend #210

pedrobaeza · 2017-11-07T19:37:07Z

Resend mass mailings

A frequent need for users of mass mailings is to resend one mailing that has already been sent in the past to new recipients that haven't received yet that mail. But the problem is to know which are the applicable ones.

Odoo already includes a method in its mass mailing logic that avoids to resend the same mail 2 times for one mass mailing, and for v9, there was a trick that allows to modify the state of a mass mailing from kanban view, covering the need.

But now on v10 both status bar in form view and dragging between states in kanban are not allowed.

This module introduces a button to restart a mass mailing to draft state, allowing you to reevaluate the sending domain or list for performing again the mailing.

Usage

Go to Mass mailing > Mailings > Mass Mailings.
Click on one record that is done or create a new one and send it.
You will see a button called "Resend".
If you click on it, mass mailing will be set to Draft again.

Known issues / Roadmap

Add an indicator / filter for knowing resent mailings.
Include information on the number of new recipients to be sent on the
resending (through get_remaining_recipients method).

@Tecnativa

yajo

Minor improvements to code. Functional test OK.

yajo · 2017-11-09T09:28:01Z

mass_mailing_resend/models/__init__.py

@@ -0,0 +1,7 @@
+# -*- coding: utf-8 -*-
+# Copyright 2015 Grupo ESOC Ingeniería de Servicios, S.L.U. - Jairo Llopis
+# Copyright 2016 Tecnativa - Vicent Cubells


Drop copyright from __init__ files

yajo · 2017-11-09T09:28:33Z

mass_mailing_resend/models/mass_mailing.py

@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Copyright 2015 Grupo ESOC Ingeniería de Servicios, S.L.U. - Jairo Llopis
+# Copyright 2016 Tecnativa - Vicent Cubells


Update copyright (it seems you copied it wrongly from elsewhere)

yajo · 2017-11-09T09:29:32Z

mass_mailing_resend/models/mass_mailing.py

+
+    def button_draft(self):
+        """Return to draft state for resending the mass mailing."""
+        if any(self.mapped(lambda x: x.state != 'done')):


if self.filtered(...):, or use a normal for loop, which is more performant since it would stop at 1st match.

In this case, as the list is going to be very short, I prefer this formula to avoid one cyclomatic level more.

In such case, use if self.filtered(...)

yajo · 2017-11-09T09:33:52Z

mass_mailing_resend/views/mass_mailing_views.xml

+        <field name="inherit_id" ref="mass_mailing.view_mail_mass_mailing_form"/>
+        <field name="arch" type="xml">
+            <field name="state" position="before">
+                <button string="Resend"


Don't you think "resend" is a bit misleading? Because you are not actually "resending" it, just setting back as draft. 🤔

A helpwould also be useful here noting that the mail will only be sent to new recipients.

I prefer resend word that is more user friendly, because setting back to draft is for resending purpose, although I'm going to add a text when clicked explaining about the new recipients.

chienandalu

It'd be nice also to have always access to the stats button box when the mailing has been sent at least one time. That's useful also to be able to delete some mails from the stats so it's possible to resend the mail to them.

chienandalu · 2017-11-21T12:45:03Z

mass_mailing_resend/views/mass_mailing_views.xml

+        <field name="inherit_id" ref="mass_mailing.view_mail_mass_mailing_form"/>
+        <field name="arch" type="xml">
+            <field name="state" position="before">
+                <button string="Resend"


A helpwould also be useful here noting that the mail will only be sent to new recipients.

Resend mass mailings ==================== A frequent need for users of mass mailings is to resend one mailing that has already been sent in the past to new recipients that haven't received yet that mail. But the problem is to know which are the applicable ones. Odoo already includes a method in its mass mailing logic that avoids to resend the same mail 2 times for one mass mailing, and for v9, there was a trick that allows to modify the state of a mass mailing from kanban view, covering the need. But now on v10 both status bar in form view and dragging between states in kanban are not allowed. This module introduces a button to restart a mass mailing to draft state, allowing you to reevaluate the sending domain or list for performing again the mailing. Usage ===== * Go to *Mass mailing > Mailings > Mass Mailings*. * Click on one record that is done or create a new one and send it. * You will see a button called "Resend". * If you click on it, mass mailing will be set to Draft again. Known issues / Roadmap ====================== * Add an indicator / filter for knowing resent mailings. * Include information on the number of new recipients to be sent on the resending (through `get_remaining_recipients` method).

pedrobaeza · 2017-11-22T10:57:13Z

Now there's a explanatory text and the buttons are back, so I think it's good enough

chienandalu

Great!

chienandalu · 2017-11-22T14:28:01Z

mass_mailing_resend/views/mass_mailing_views.xml

@@ -12,6 +12,16 @@
                        type="object"
                />
            </field>
+            <header position="after">
+                <div class="alert alert-warning oe_text_center" attrs="{'invisible': ['|', ('state', '!=', 'draft'), ('sent', '=', '0')]}">


Following the flow: shouldn't this be more like:

{'invisible': ['|', ('state', '=', 'done'), ('state', '!=', 'done'), ('sent', '=', '0')]}

So it's only visible when a mailing is reset to draft and it has sent mails. Otherwise it's visible at the first composition.

No, it's correct as it's now: it's only visible when on draft and sent > 0.

Isn't it when draft or sent = 0

I don't get you. Please re-read my comment

Ok, yeah. I got it wrong because the second condition doesn't seem to be working fine. When you create a new draft mailing the bubble is visible (maybe is False until the field is computed by the first time?)

Ok, it was more subtle than that 😄 The quotes in ('sent', '=', '0') are avoiding proper evaluation. So, this should work:

{'invisible': ['|', ('state', '!=', 'draft'), ('sent', '=', 0)]}

yajo · 2018-01-23T10:52:17Z

@pedrobaeza Can I squash and merge?

pedrobaeza · 2018-01-23T11:01:37Z

Yes, please

* [ADD] mass_mailing_resend Resend mass mailings ==================== A frequent need for users of mass mailings is to resend one mailing that has already been sent in the past to new recipients that haven't received yet that mail. But the problem is to know which are the applicable ones. Odoo already includes a method in its mass mailing logic that avoids to resend the same mail 2 times for one mass mailing, and for v9, there was a trick that allows to modify the state of a mass mailing from kanban view, covering the need. But now on v10 both status bar in form view and dragging between states in kanban are not allowed. This module introduces a button to restart a mass mailing to draft state, allowing you to reevaluate the sending domain or list for performing again the mailing. Usage ===== * Go to *Mass mailing > Mailings > Mass Mailings*. * Click on one record that is done or create a new one and send it. * You will see a button called "Resend". * If you click on it, mass mailing will be set to Draft again. Known issues / Roadmap ====================== * Add an indicator / filter for knowing resent mailings. * Include information on the number of new recipients to be sent on the resending (through `get_remaining_recipients` method).

pedrobaeza added the needs review label Nov 7, 2017

pedrobaeza added this to the 10.0 milestone Nov 7, 2017

yajo approved these changes Nov 9, 2017

View reviewed changes

chienandalu reviewed Nov 21, 2017

View reviewed changes

pedrobaeza added 2 commits November 22, 2017 11:07

fixup! [ADD] mass_mailing_resend

e9a49cc

pedrobaeza force-pushed the 10.0-mass_mailing_resend branch from 8e37dd6 to e9a49cc Compare November 22, 2017 10:50

chienandalu approved these changes Nov 22, 2017

View reviewed changes

chienandalu reviewed Nov 22, 2017

View reviewed changes

fixup! [ADD] mass_mailing_resend

59d951a

yajo merged commit a185b2c into OCA:10.0 Jan 23, 2018

yajo deleted the 10.0-mass_mailing_resend branch January 23, 2018 12:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] mass_mailing_resend #210

[ADD] mass_mailing_resend #210

pedrobaeza commented Nov 7, 2017

yajo left a comment •

edited

Loading

yajo Nov 9, 2017

yajo Nov 9, 2017

yajo Nov 9, 2017

pedrobaeza Nov 22, 2017

yajo Nov 30, 2017

yajo Nov 9, 2017

chienandalu Nov 21, 2017

pedrobaeza Nov 22, 2017

chienandalu left a comment

chienandalu Nov 21, 2017

pedrobaeza commented Nov 22, 2017

chienandalu left a comment

chienandalu Nov 22, 2017

pedrobaeza Nov 22, 2017

chienandalu Nov 24, 2017

pedrobaeza Nov 24, 2017

chienandalu Nov 27, 2017

chienandalu Jan 8, 2018

pedrobaeza Jan 8, 2018

yajo commented Jan 23, 2018

pedrobaeza commented Jan 23, 2018

[ADD] mass_mailing_resend #210

[ADD] mass_mailing_resend #210

Conversation

pedrobaeza commented Nov 7, 2017

Resend mass mailings

Usage

Known issues / Roadmap

yajo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 22, 2017

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Jan 23, 2018

pedrobaeza commented Jan 23, 2018

yajo left a comment •

edited

Loading