-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] mail_optional_autofollow #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbeficent @yajo it's ok for merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code OK.
Please squash all migration-related commits to merge.
as @jbeficent's comments seem to be fixed, I'll merge |
Well, there's a lot of commit noise, so next time you can use your super-powers for squashing selectively them before merging. |
is there a convenient way to do this without checking out locally, doing the rebase there and force pushing? |
I'm afraid not. I do it locally, but I agree it's not the more comfortable thing to do. I have taught all my colleagues now to do forced push when changing PRs as GitHub has included the option to see the diff when you do this operation, so no extra action is required when merging. |
hmmm, okay, thanks. So I'll keep asking people to squash themselves, I always dislike it when my signature is squashed away. |
Yeah, that's another thing when manipulating commits... 😢 I think we can start to ask to forced push in the PRs instead. |
No description provided.