Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] mail restrict follower selection #239

Merged
merged 7 commits into from
Mar 13, 2018

Conversation

phucngta
Copy link
Contributor

No description provided.

@phucngta phucngta changed the title 11.0 mig mail restrict follower selection [11.0][MIG] mail restrict follower selection Feb 28, 2018
@pedrobaeza pedrobaeza added this to the 11.0 milestone Feb 28, 2018
@pedrobaeza pedrobaeza mentioned this pull request Feb 28, 2018
26 tasks
@@ -0,0 +1,20 @@
##############################################################################
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch to the shorter version?

# 2015 Therp BV <http://therp.nl>
# 2017 Komit <http://www.komit-consulting.com>
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).`

Also, I am not sure if it is ok to add Komit to the copyrights for a migration.

@OCA/core-maintainers should there be any mention about the good practice in the migration guideline page: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pull request OCA/web#738, @moylop260 asked me to keep original Copyright so i don't want to switch this to the shorter version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine to shorten this, keeping the copyright means not to delete the names. So I agree with @jcdrubay's proposal


The development of this module has been financially supported by:

* Komit https://komit-consulting.com
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Funders section can be removed as it is not applicable.

Komit is not a funder as their was no financial contribution, only time (and sweat).

{
"name": "Restrict follower selection",
"version": "11.0.1.0.0",
"author": "Komit, "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that Komit is not the author as Komit only takes care of the migration.

For a migration, I think that Komit should only be added as a contributor, in the README.rst

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, author stays Therp BV and the OCA

#
##############################################################################
from lxml import etree
from odoo import models, api
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please order the imports:

from odoo import api, models

@phucngta phucngta force-pushed the 11.0-mig-mail_restrict_follower_selection branch from 32ee850 to f78e247 Compare March 6, 2018 08:29
@phucngta phucngta force-pushed the 11.0-mig-mail_restrict_follower_selection branch from f78e247 to 14aaca5 Compare March 6, 2018 08:39
Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test on my local database

@hbrunn
Copy link
Member

hbrunn commented Mar 12, 2018

please fix

module mail_restrict_follower_selection: creating or updating database tables
<string>:3: (WARNING/2) Explicit markup ends without a blank line; unexpected unindent.
2018-03-06 17:57:58,873 166 WARNING openerp_test odoo.addons.base.module.module: docutils' system message present: <system_message level="2" line="3" source="<string>" type="WARNING"><paragraph>Explicit markup ends without a blank line; unexpected unindent.</paragraph></system_message>

then we can merge

@phucngta phucngta force-pushed the 11.0-mig-mail_restrict_follower_selection branch 3 times, most recently from 74f0a7a to f64cddc Compare March 13, 2018 05:18
@phucngta phucngta force-pushed the 11.0-mig-mail_restrict_follower_selection branch from f64cddc to 72f2d47 Compare March 13, 2018 05:38
@phucngta
Copy link
Contributor Author

@hbrunn It's fixed

@hbrunn hbrunn merged commit 5a74573 into OCA:11.0 Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants