-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] mail restrict follower selection #239
[11.0][MIG] mail restrict follower selection #239
Conversation
@@ -0,0 +1,20 @@ | |||
############################################################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we switch to the shorter version?
# 2015 Therp BV <http://therp.nl>
# 2017 Komit <http://www.komit-consulting.com>
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).`
Also, I am not sure if it is ok to add Komit to the copyrights for a migration.
@OCA/core-maintainers should there be any mention about the good practice in the migration guideline page: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In pull request OCA/web#738, @moylop260 asked me to keep original Copyright so i don't want to switch this to the shorter version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's fine to shorten this, keeping the copyright
means not to delete the names. So I agree with @jcdrubay's proposal
|
||
The development of this module has been financially supported by: | ||
|
||
* Komit https://komit-consulting.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that Funders section can be removed as it is not applicable.
Komit is not a funder as their was no financial contribution, only time (and sweat).
{ | ||
"name": "Restrict follower selection", | ||
"version": "11.0.1.0.0", | ||
"author": "Komit, " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that Komit is not the author as Komit only takes care of the migration.
For a migration, I think that Komit should only be added as a contributor, in the README.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, author stays Therp BV and the OCA
# | ||
############################################################################## | ||
from lxml import etree | ||
from odoo import models, api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order the imports:
from odoo import api, models
32ee850
to
f78e247
Compare
f78e247
to
14aaca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and test on my local database
please fix
then we can merge |
74f0a7a
to
f64cddc
Compare
f64cddc
to
72f2d47
Compare
@hbrunn It's fixed |
No description provided.