[11][MIG] email_template_qweb: Migration to 11.0 #250

celm1990 · 2018-03-25T18:29:10Z

PR replace #249
Sorry for create and close various PR. Is my first contribution

pedrobaeza · 2018-03-25T18:34:33Z

@celm1990 next time, for avoiding opening more PRs, you just need to use git push -f for overwriting the branch with the new contents. Please try next time or ask me and I'll teach you.

simahawk · 2018-04-06T07:27:13Z

email_template_qweb/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+    :alt: Try me on Runbot
+    :target: https://runbot.odoo-community.org/runbot/205/10.0


simahawk · 2018-04-06T07:27:41Z

email_template_qweb/README.rst

+Demo data contains an example on how to separate corporate identity from a
+template's content.
+
+For further information, please visit:


update whole README according to latest template https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

simahawk · 2018-04-06T07:27:54Z

email_template_qweb/__init__.py

@@ -0,0 +1,4 @@
+# -*- coding: utf-8 -*-


remove coding headers

simahawk · 2018-04-06T07:28:11Z

email_template_qweb/__init__.py

@@ -0,0 +1,4 @@
+# -*- coding: utf-8 -*-
+# © 2016 Therp BV <http://therp.nl>


replace (c) symbol w/ "Copyright"

simahawk · 2018-04-06T07:28:40Z

email_template_qweb/__manifest__.py

+    "author": "Therp BV,Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "category": "Marketing",
+    "summary": "Use the QWeb templating mechanism for emails",


add 'website': 'https://github.com/OCA/social',

simahawk · 2018-04-06T07:30:00Z

email_template_qweb/models/mail_template.py

+        default='jinja2', required=True)
+    body_view_id = fields.Many2one(
+        'ir.ui.view', 'Body view', domain=[('type', '=', 'qweb')])
+    body_view_arch = fields.Text(related=['body_view_id', 'arch'])


related='body_view_id.arch'?

simahawk · 2018-04-06T07:30:30Z

email_template_qweb/models/mail_template.py

+        result = super(MailTemplate, self).generate_email(
+            res_ids, fields=fields
+        )
+        for record_id, this in self.get_email_template(res_ids).items():


we are not in JS here: change this w/ record?

simahawk · 2018-04-06T07:32:21Z

email_template_qweb/models/mail_template.py

+                        'object': record,
+                        'email_template': this,
+                    })
+                    # Some wizards, like when sending a sales order, need this


still the case w/ Odoo 11 and py3?

simahawk · 2018-04-06T07:33:00Z

email_template_qweb/tests/test_mail_template_qweb.py

+        self.assertTrue(
+            # this comes from the called template if everything worked
+            '<footer>' in mail_values[self.env.user.id]['body_html'],
+            'Did not rcv rendered template in response. Got: \n%s\n' % (


s/rcv/??? "receive"?

hbrunn · 2018-04-09T07:38:00Z

email_template_qweb/models/mail_template.py

@@ -33,7 +33,7 @@ def generate_email(self, res_ids, fields=None):
                    })
                    # Some wizards, like when sending a sales order, need this
                    # fix to display accents correctly
-                    if not isinstance(body_html, unicode):
+                    if not isinstance(body_html, str):


I think we'll be better off with using https://github.com/OCA/OCB/blob/11.0/odoo/loglevels.py#L43 here

tschanzt

Only some minor nitpicking.

tschanzt · 2018-04-17T15:24:28Z

email_template_qweb/models/mail_template.py

@@ -0,0 +1,43 @@
+


can your remove the empty line here?

tschanzt · 2018-04-17T15:24:37Z

email_template_qweb/models/__init__.py

@@ -0,0 +1,4 @@
+


can your remove the empty line here?

simahawk

@celm1990 LGTM but module version. @tschanzt can you update your review?
@hbrunn can you do yours? :)

simahawk · 2018-04-26T10:50:54Z

email_template_qweb/__manifest__.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+{
+    "name": "QWeb for email templates",
+    "version": "10.0.1.0.0",


simahawk · 2018-04-26T10:52:19Z

also, whe you are done, squash your commits pls :)

tschanzt

Apart from the things @simahawk mentioned it looks good to me.

hbrunn

same here

pedrobaeza · 2018-04-27T11:57:49Z

@celm1990 please make the little remaining things to merge this.

celm1990 · 2018-05-10T02:23:23Z

@pedrobaeza is ok or something is missing???

simahawk · 2018-05-10T07:08:03Z

@celm1990 this comment seems unattended #250 (comment)
compare "bug tracker" and "contributor" sections w/ the template I linked ;)

simahawk

Overall LGTM. Approving to not get back, but check README again ;)

celm1990 · 2018-05-10T14:31:31Z

@simahawk Done, update readme.rst.

rafaelbn · 2018-05-11T01:43:48Z

email_template_qweb/README.rst

+#. Select `QWeb` in the field `Body templating engine`
+#. Select a QWeb view to be used to render the body field
+#. Apart from QWeb's standard variables, you also have access to ``object`` and ``email_template``, which are browse records of the current object and the email template in use, respectively.
+#. Go to ...


You can delete this line

…ne id (OCA#65) fixes OCA#64

If the result is of type unicode, render method encodes it in utf-8. We need to decode it in that case so that the rendering results correct.

celm1990 mentioned this pull request Mar 25, 2018

[11][MIG] email_template_qweb: Migration to 11.0 #249

Closed

pedrobaeza mentioned this pull request Mar 25, 2018

Migration to version 11.0 #203

Closed

26 tasks

simahawk requested changes Apr 6, 2018

View reviewed changes

hbrunn reviewed Apr 9, 2018

View reviewed changes

tschanzt suggested changes Apr 17, 2018

View reviewed changes

simahawk requested changes Apr 26, 2018

View reviewed changes

tschanzt approved these changes Apr 26, 2018

View reviewed changes

hbrunn approved these changes Apr 26, 2018

View reviewed changes

celm1990 force-pushed the 11.0-mig-email_template_qweb branch 2 times, most recently from 9dd3892 to 0aed142 Compare April 27, 2018 19:38

rafaelbn added this to the 11.0 milestone Apr 28, 2018

simahawk approved these changes May 10, 2018

View reviewed changes

celm1990 force-pushed the 11.0-mig-email_template_qweb branch from bd21ca6 to 4c48870 Compare May 10, 2018 14:30

rafaelbn approved these changes May 11, 2018

View reviewed changes

celm1990 force-pushed the 11.0-mig-email_template_qweb branch 3 times, most recently from 58f1a51 to 2de67e8 Compare May 11, 2018 02:09

lasley and others added 6 commits May 15, 2018 16:33

[ADD] email_template_qweb

9b83f6f

[FIX] Call to generate_email can be done with a list of ids or only o…

55fa0d0

…ne id (OCA#65) fixes OCA#64

[MIG] email_template_qweb: Migrated to 10.0

33c0644

[FIX] email_template_qweb: Decode body when encoded

67a4bab

If the result is of type unicode, render method encodes it in utf-8. We need to decode it in that case so that the rendering results correct.

OCA Transbot updated translations from Transifex

731d031

[11][MIG] email_template_qweb: Migration to 11.0

80436ac

pedrobaeza force-pushed the 11.0-mig-email_template_qweb branch from 2de67e8 to 80436ac Compare May 15, 2018 14:33

pedrobaeza approved these changes May 15, 2018

View reviewed changes

pedrobaeza merged commit 057aa7b into OCA:11.0 May 15, 2018

celm1990 deleted the 11.0-mig-email_template_qweb branch May 15, 2018 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11][MIG] email_template_qweb: Migration to 11.0 #250

[11][MIG] email_template_qweb: Migration to 11.0 #250

celm1990 commented Mar 25, 2018

pedrobaeza commented Mar 25, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

simahawk Apr 6, 2018

hbrunn Apr 9, 2018

tschanzt left a comment

tschanzt Apr 17, 2018

tschanzt Apr 17, 2018

simahawk left a comment

simahawk Apr 26, 2018

simahawk commented Apr 26, 2018

tschanzt left a comment

hbrunn left a comment

pedrobaeza commented Apr 27, 2018

celm1990 commented May 10, 2018

simahawk commented May 10, 2018

simahawk left a comment

celm1990 commented May 10, 2018

rafaelbn May 11, 2018

		@@ -0,0 +1,4 @@
		# -- coding: utf-8 --
		# © 2016 Therp BV <http://therp.nl>

[11][MIG] email_template_qweb: Migration to 11.0 #250

[11][MIG] email_template_qweb: Migration to 11.0 #250

Conversation

celm1990 commented Mar 25, 2018

pedrobaeza commented Mar 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschanzt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk commented Apr 26, 2018

tschanzt left a comment

Choose a reason for hiding this comment

hbrunn left a comment

Choose a reason for hiding this comment

pedrobaeza commented Apr 27, 2018

celm1990 commented May 10, 2018

simahawk commented May 10, 2018

simahawk left a comment

Choose a reason for hiding this comment

celm1990 commented May 10, 2018

Choose a reason for hiding this comment