[MIG] base_search_mail_content: Migration to 11.0 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jun 11, 2018
| </record> | ||
|
|
||
| <record model="ir.ui.view" id="trgm_index_view_tree"> | ||
| <!--<record model="ir.ui.view" id="trgm_index_view_tree"> |
There was a problem hiding this comment.
If it's not needed, it's better to remove it. Git will keep it if needed.
yajo
requested changes
Jun 12, 2018
| @@ -0,0 +1,6 @@ | |||
| This module depends on the module 'base_search_fuzzy' to ensure that | |||
| searches on emails are based on indexes. Please read carefully the | |||
| `install instructions <https://github.com/OCA/server-tools/blob/10.0/base_search_fuzzy/README.rst>`_. | |||
There was a problem hiding this comment.
Not sure if we should link the README now that it is split... Maybe better the odoo apps site? Besides, it's v10 branch.
| </record> | ||
|
|
||
| <record model="ir.ui.view" id="trgm_index_view_tree"> | ||
| <!--<record model="ir.ui.view" id="trgm_index_view_tree"> |
There was a problem hiding this comment.
If it's not needed, it's better to remove it. Git will keep it if needed.
|
@yajo done! Can you recheck? |
yajo
approved these changes
Jun 12, 2018
cubells
force-pushed
the
11.0-mig-base_search_mail_content
branch
from
8daa918
to
c946c83
Compare
|
Please @cubells rebase! |
Introduce search of html fields Create indexes Update Readme
cubells
force-pushed
the
11.0-mig-base_search_mail_content
branch
from
c946c83
to
d93a722
Compare
|
@rafaelbn done! |
cubells
force-pushed
the
11.0-mig-base_search_mail_content
branch
from
d93a722
to
caf6355
Compare
|
Thanks @cubells ! Please review translation
|
cubells
force-pushed
the
11.0-mig-base_search_mail_content
branch
from
caf6355
to
fee986f
Compare
|
@yajo @pedrobaeza this is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
cc @Tecnativa