[11.0][ADD][mail_activity_team] #330

JordiBForgeFlow · 2018-11-27T08:39:15Z

This module adds the possibility to assign teams to activities.

Usage

To set up new teams:

#. Go to Settings / Activate developer mode
#. Go to Settings / Technical / Email / Activity Teams
#. Create a new Team and assign (optionally) the models in which it will
be used, and the members of the team.

You can also assign a user to Activity teams going to
Settings / Users & Companies / Users, and in the Preferences tab, field
Activity Teams.

When you create a new activity the application will propose the user's
assigned team.

You can report on the activities assigned to a team going to
Dashboards / Activities, and then filter by a specific team or group by
teams.

JordiBForgeFlow · 2018-11-27T08:39:42Z

@mreficent Can you please add tests?

JordiBForgeFlow · 2018-11-27T08:41:34Z

@mreficent We also need a button in the team that counts how many mail activities meet the model and members of the team, but have no team assigned. The user should be able to click this button to start a wizard that should update, for these activities, the new team.

HviorForgeFlow · 2018-11-27T08:53:07Z

mail_activity_team/security/ir.model.access.csv

+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
+access_mail_activity_team_all,mail.activity.team.all,model_mail_activity_team,,1,0,0,0
+access_mail_activity_team_user,mail.activity.team.user,model_mail_activity_team,base.group_user,1,1,0,0
+access_mail_activity_team_system_user,mail.activity.team.system.user,model_mail_activity_team,base.group_system_user,1,1,1,1


base.group_system_user does not exist use instead base.group_system

HviorForgeFlow · 2018-11-27T10:03:00Z

mail_activity_team/security/mail_activity_team_security.xml

+    <record id="mail_activity_rule_my_team" model="ir.rule">
+        <field name="name">mail.activity: user: my team</field>
+        <field name="model_id" ref="mail.model_mail_activity"/>
+        <field name="domain_force">['|', '&amp;'('team_id', '=', False),('user_id', '=', user.id),('team_id', '=', user.team_ids.ids)]</field>


Suggested change

<field name="domain_force">['|', '&'('team_id', '=', False),('user_id', '=', user.id),('team_id', '=', user.team_ids.ids)]</field>

<field name="domain_force">["|", ('team_id', 'in', user.activity_team_ids.ids), "&", ('team_id', '=', False), ('user_id', '=', user.id)]</field>

HviorForgeFlow · 2018-11-27T11:14:13Z

mail_activity_team/views/mail_activity_team_views.xml

+                            <field name="name"/>
+                        </group>
+                        <group name="models">
+                            <field name="res_model_ids" widget="many2many_tags"/>


Suggested change

<field name="res_model_ids" widget="many2many_tags"/>

<field name="res_model_ids" widget="many2many_tags"

options="{'no_create': True, 'no_open': True}"/>

JordiBForgeFlow · 2018-11-27T11:35:51Z

mail_activity_team/models/mail_activity_team.py

+
+    name = fields.Char(string='Name', required=True, translate=True)
+    active = fields.Boolean(string='Active', default=True)
+    res_model_ids = fields.Many2many('ir.model', string='Used models')


@mreficent can you check how it would be possible to add a domain here that only shows the models that inherit the activity.mixin? Otherwise it is very confusing for the user to see all models here, most of which do not allow to add activities.

MiquelRForgeFlow · 2018-11-28T14:48:48Z

The WIP label should be changed to needs review

hbrunn · 2018-11-29T07:39:32Z

mail_activity_team/models/mail_activity.py

+    _inherit = "mail.activity"
+
+    def _get_default_team_id(self):
+        res_model = self.env.context.get('default_res_model', False)


does it matter if you get False or None here?

what do you mean?

dict.get returns None if the key doesn't exist and you didn't pass another default. So to rephrase: What's the , False) part good for?

mail_activity_team/models/mail_activity_team.py

hbrunn · 2018-11-29T07:43:26Z

mail_activity_team/models/mail_activity_team.py

+            if team.res_model_ids:
+                domain.append(('res_model_id', 'in', team.res_model_ids.ids))
+            team.count_missing_activities = len(
+                activity_model.search(domain)


pass count=True instead of using len on the results

hbrunn · 2018-11-29T07:46:02Z

mail_activity_team/models/mail_activity_team.py

+        default=0,
+    )
+
+    def action_missing_activities(self):


this function name sounds a bit misleading, shouldn't it be something like assign_team_to_unassigned_activities?

MiquelRForgeFlow · 2018-11-29T11:14:30Z

@hbrunn changes done :)

LoisRForgeFlow

Functional review:
When you first create an activity it does not show any team:

If you remove the user assigned to, they show all up. All teams should be selectable at the beggining (or at least the ones the user assigned is member of).

LoisRForgeFlow · 2018-11-29T14:46:08Z

mail_activity_team/views/res_users_views.xml

+        <field name="arch" type="xml">
+            <data>
+                <field name="signature" position="before">
+                    <field name="activity_team_ids" widget="many2many_tags"/>


The label is not displayed.

If you test in local, you see that the label is displayed. Maybe it's not displayed due to another module of the repository

It's due to mail_digest module

MiquelRForgeFlow · 2018-11-29T15:59:32Z

(or at least the ones the user assigned is member of)

that's how it works now. but I will improve it

LoisRForgeFlow · 2018-11-29T16:46:37Z

yes, after removing the user and selecting a team, the first time no team show up.

etobella

Interesting module!
However, I miss the filter My teams activities on the dashboard. This way, I know which activities are assigned to my team.
Also, If only one member of the team exists, you should assign it automatically.

HviorForgeFlow

LGTM 👍

etobella

LGTM 👍

JordiBForgeFlow · 2018-12-24T13:33:09Z

@ageficent on runbot, when I go to a team and press 'Assign to missing activities' I am getting this error:

LoisRForgeFlow

LGTM 👍

LoisRForgeFlow · 2019-01-08T16:16:38Z

merge? 🤔

JordiBForgeFlow requested review from LoisRForgeFlow, HviorForgeFlow and MiquelRForgeFlow November 27, 2018 08:39

JordiBForgeFlow added the work in progress label Nov 27, 2018

HviorForgeFlow reviewed Nov 27, 2018

View reviewed changes

JordiBForgeFlow commented Nov 27, 2018

View reviewed changes

MiquelRForgeFlow force-pushed the 11.0-mail_activity_team branch 2 times, most recently from 6c3bbf1 to 92da1e7 Compare November 28, 2018 14:12

hbrunn added needs review and removed work in progress labels Nov 29, 2018

hbrunn added this to the 11.0 milestone Nov 29, 2018

hbrunn requested changes Nov 29, 2018

View reviewed changes

MiquelRForgeFlow force-pushed the 11.0-mail_activity_team branch from 92da1e7 to 8f47f02 Compare November 29, 2018 11:12

hbrunn approved these changes Nov 29, 2018

View reviewed changes

LoisRForgeFlow reviewed Nov 29, 2018

View reviewed changes

MiquelRForgeFlow force-pushed the 11.0-mail_activity_team branch 7 times, most recently from 7501f48 to 180ca02 Compare November 30, 2018 12:41

MiquelRForgeFlow force-pushed the 11.0-mail_activity_team branch from 180ca02 to 2043e3e Compare November 30, 2018 12:43

MiquelRForgeFlow mentioned this pull request Dec 3, 2018

[12.0][MIG] mail_activity_team #340

Closed

1 task

etobella reviewed Dec 14, 2018

View reviewed changes

AdriaGForgeFlow force-pushed the 11.0-mail_activity_team branch 3 times, most recently from ade4bef to cf57f33 Compare December 24, 2018 09:04

HviorForgeFlow approved these changes Dec 24, 2018

View reviewed changes

OCA-git-bot added the approved label Dec 24, 2018

etobella approved these changes Dec 24, 2018

View reviewed changes

AdriaGForgeFlow force-pushed the 11.0-mail_activity_team branch from 37ee943 to 3da7001 Compare January 2, 2019 12:12

JordiBForgeFlow and others added 6 commits January 2, 2019 13:14

[ADD] mail_activity_team

de66781

[IMP] Some improvements and fixes

2d0d025

[ADD] tests

293e155

[IMP] Set team responsible as default user when activity is created

f0ec97a

Add search filter for my team activities

7b7a61a

fixup!

de777d3

AdriaGForgeFlow force-pushed the 11.0-mail_activity_team branch from 3da7001 to de777d3 Compare January 2, 2019 12:14

LoisRForgeFlow approved these changes Jan 3, 2019

View reviewed changes

MiquelRForgeFlow approved these changes Jan 8, 2019

View reviewed changes

hbrunn merged commit 29ef70f into OCA:11.0 Jan 8, 2019

MiquelRForgeFlow deleted the 11.0-mail_activity_team branch January 8, 2019 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][ADD][mail_activity_team] #330

[11.0][ADD][mail_activity_team] #330

JordiBForgeFlow commented Nov 27, 2018

JordiBForgeFlow commented Nov 27, 2018

JordiBForgeFlow commented Nov 27, 2018

HviorForgeFlow Nov 27, 2018

HviorForgeFlow Nov 27, 2018 •

edited

Loading

HviorForgeFlow Nov 27, 2018

JordiBForgeFlow Nov 27, 2018

MiquelRForgeFlow commented Nov 28, 2018

hbrunn Nov 29, 2018

MiquelRForgeFlow Nov 29, 2018

hbrunn Nov 29, 2018

hbrunn Nov 29, 2018

hbrunn Nov 29, 2018

MiquelRForgeFlow commented Nov 29, 2018

LoisRForgeFlow left a comment

LoisRForgeFlow Nov 29, 2018

MiquelRForgeFlow Nov 29, 2018

MiquelRForgeFlow Nov 30, 2018 •

edited

Loading

MiquelRForgeFlow commented Nov 29, 2018

LoisRForgeFlow commented Nov 29, 2018

etobella left a comment

HviorForgeFlow left a comment

etobella left a comment

JordiBForgeFlow commented Dec 24, 2018

LoisRForgeFlow left a comment

LoisRForgeFlow commented Jan 8, 2019

	<field name="domain_force">['\|', '&'('team_id', '=', False),('user_id', '=', user.id),('team_id', '=', user.team_ids.ids)]</field>
	<field name="domain_force">["\|", ('team_id', 'in', user.activity_team_ids.ids), "&", ('team_id', '=', False), ('user_id', '=', user.id)]</field>

	<field name="res_model_ids" widget="many2many_tags"/>
	<field name="res_model_ids" widget="many2many_tags"
	options="{'no_create': True, 'no_open': True}"/>

[11.0][ADD][mail_activity_team] #330

[11.0][ADD][mail_activity_team] #330

Conversation

JordiBForgeFlow commented Nov 27, 2018

Usage

JordiBForgeFlow commented Nov 27, 2018

JordiBForgeFlow commented Nov 27, 2018

Choose a reason for hiding this comment

HviorForgeFlow Nov 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MiquelRForgeFlow commented Nov 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MiquelRForgeFlow commented Nov 29, 2018

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MiquelRForgeFlow Nov 30, 2018 • edited Loading

Choose a reason for hiding this comment

MiquelRForgeFlow commented Nov 29, 2018

LoisRForgeFlow commented Nov 29, 2018

etobella left a comment

Choose a reason for hiding this comment

HviorForgeFlow left a comment

Choose a reason for hiding this comment

etobella left a comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Dec 24, 2018

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Jan 8, 2019

HviorForgeFlow Nov 27, 2018 •

edited

Loading

MiquelRForgeFlow Nov 30, 2018 •

edited

Loading