Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] mail_activity_board #338

Merged
merged 6 commits into from
Mar 26, 2019
Merged

[12.0][MIG] mail_activity_board #338

merged 6 commits into from
Mar 26, 2019

Conversation

MiquelRForgeFlow
Copy link
Contributor

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 3, 2018
@MiquelRForgeFlow MiquelRForgeFlow changed the title 12.0 mig mail activity board [12.0][IG] mail_activity_board Dec 3, 2018
@MiquelRForgeFlow MiquelRForgeFlow changed the title [12.0][IG] mail_activity_board [12.0][MIG] mail_activity_board Dec 3, 2018
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Dec 3, 2018
Closed
1 task
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-mail_activity_board branch 2 times, most recently from b8273d3 to 2e2aa93 Compare December 14, 2018 12:02
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 29, 2018
Closed
24 tasks
@hbrunn hbrunn added needs review needs tests This PR is correct, but lowers test coverage labels Jan 9, 2019
@MiquelRForgeFlow
Copy link
Contributor Author

Hello everybody, the tests have been added! update reviews please!

@hbrunn please, remove "needs tests" tag.

@hbrunn hbrunn removed the needs tests This PR is correct, but lowers test coverage label Mar 15, 2019
LoisRForgeFlow
LoisRForgeFlow approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

@emagdalenaC2i
Copy link
Contributor

I get this error in runbot when I set the Future Activities filter in the Activities board:
Error:
Odoo Server Error

Traceback (most recent call last):
File "/.repo_requirements/odoo/odoo/http.py", line 654, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/.repo_requirements/odoo/odoo/http.py", line 312, in _handle_exception
raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
File "/.repo_requirements/odoo/odoo/tools/pycompat.py", line 87, in reraise
raise value
File "/.repo_requirements/odoo/odoo/http.py", line 696, in dispatch
result = self._call_function(**self.params)
File "/.repo_requirements/odoo/odoo/http.py", line 344, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/service/model.py", line 97, in wrapper
return f(dbname, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/http.py", line 337, in checked_call
result = self.endpoint(*a, **kw)
File "/.repo_requirements/odoo/odoo/http.py", line 939, in call
return self.method(*args, **kw)
File "/.repo_requirements/odoo/odoo/http.py", line 517, in response_wrap
response = f(*args, **kw)
File "/home/odoo/OCB-12.0/addons/web/controllers/main.py", line 962, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/home/odoo/OCB-12.0/addons/web/controllers/main.py", line 954, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/.repo_requirements/odoo/odoo/api.py", line 745, in call_kw
return _call_kw_model(method, model, args, kwargs)
File "/.repo_requirements/odoo/odoo/api.py", line 718, in _call_kw_model
result = method(recs, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/models.py", line 2070, in read_group
result = self._read_group_raw(domain, fields, groupby, offset=offset, limit=limit, orderby=orderby, lazy=lazy)
File "/.repo_requirements/odoo/odoo/models.py", line 2093, in _read_group_raw
query = self._where_calc(domain)
File "/.repo_requirements/odoo/odoo/models.py", line 3869, in _where_calc
e = expression.expression(domain, self)
File "/.repo_requirements/odoo/odoo/osv/expression.py", line 672, in init
self.parse()
File "/.repo_requirements/odoo/odoo/osv/expression.py", line 853, in parse
raise ValueError("Invalid field %r in leaf %r" % (left, str(leaf)))
ValueError: Invalid field 'activity_ids.date_deadline' in leaf "<osv.ExtendedLeaf: ('activity_ids.date_deadline', '>', '2019-03-24') on mail_activity (ctx: )>"

dajuayen and others added 5 commits March 25, 2019 12:21
@dajuayen @MiquelRForgeFlow
[ADD][mail_activity_board] Add new module that insert activities boar…
6155509 
…d in boards. (OCA#283)

* [ADD] Module that insert activities board.

* [FIX] Author error in __manifest__ file and style changes.

* [FIX] Fix replace in view, rename files and style changes.

* [FIX] Enumerated list ends without a blank line; unexpected unindent.

* [FIX] Name fail.

* [FIX] Bug in view.

* [FIX]  Add button Activities in mail.thread and readme folder. Others improvements in style of code.

* [FIX] Type 'tree' not found in registry: problem solved.

* [FIX] Dependence change: 'mail' for 'calendar'.

* [FIX] Eliminated unnecessary imports.

* [FIX] Bugs about js and if/else.

* [FIX] Improvements following guide lines and eliminating unnecessary attributes in views.

* [ADD] Added counter in the 'Activities List' button.

* [FIX] Bugs in javascript with 'Activities' button.

* [ADD] Tests folder.

* [FIX] Deleted references to modules not installed.

* [FIX] Formatting javascript.

* [FIX] Bug: added a soft line before a class.

* [FIX] Bug: OCA#283 (comment)

* [FIX] Escaping 'lt' in xml file. Bug: OCA#283 (comment)

* [FIX] The meeting attendees are shown in kanban mode on the meeting board.

* [FIX] Hide in form view of the activity board the assistant field if the activity is not a meeting type or if there are no assistants.

* [FIX] Change to default kanban view for partners.
@OCA-git-bot @MiquelRForgeFlow
[UPD] README.rst
c86a574
@oca-travis @MiquelRForgeFlow
[UPD] Update mail_activity_board.pot
c5b0d06
@MiquelRForgeFlow
[IMP] mail_activity_board: filter activities by user read permissions
fd6e378
@MiquelRForgeFlow
[MIG] mail_activity_board: Migration to 12.0
70b5a76
@MiquelRForgeFlow
Copy link
Contributor Author

@emagdalenaC2i How I can reproduce your error? Can you provide better detail of the steps to follow?

@JordiBForgeFlow
Copy link
Sponsor Member

@mreficent #337 has been merged. Can you rebase?

@MiquelRForgeFlow
Copy link
Contributor Author

@jbeficent no need to rebase, the #337 is already included.

@emagdalenaC2i
Copy link
Contributor

@mreficent I just created two activities in runbot, one scheduled for today and the other one in the future
I mark the future activity as Done and set the Future Activities filter.

In that case there will be none Future activity but I get that error

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MiquelRForgeFlow
Copy link
Contributor Author

@emagdalenaC2i fixed your issue. It was due to mail_activity_done module.

@MiquelRForgeFlow
Copy link
Contributor Author

FYI @ageficent

@MiquelRForgeFlow
Copy link
Contributor Author

backported in #370

@emagdalenaC2i emagdalenaC2i mentioned this pull request Mar 25, 2019
Merged
@JordiBForgeFlow JordiBForgeFlow merged commit 893a6d3 into OCA:12.0 Mar 26, 2019
@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-mail_activity_board branch March 26, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@emagdalenaC2i emagdalenaC2i emagdalenaC2i approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MiquelRForgeFlow @emagdalenaC2i @JordiBForgeFlow @OCA-git-bot @LoisRForgeFlow @hbrunn @pedrobaeza @dajuayen @oca-travis