Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 mig email_template_qweb #341

Merged
merged 8 commits into from
Dec 20, 2018

Conversation

ernestotejeda
Copy link
Member

@ernestotejeda ernestotejeda commented Dec 12, 2018

hbrunn
hbrunn previously requested changes Dec 12, 2018
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good

email_template_qweb/__manifest__.py Outdated Show resolved Hide resolved
@hbrunn hbrunn added this to the 12.0 milestone Dec 12, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 12, 2018
24 tasks
Copy link
Member

@cristinamartinrod cristinamartinrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@pedrobaeza pedrobaeza dismissed hbrunn’s stale review December 20, 2018 09:47

Comment has been honored

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbrunn's comment about authorship has been honored (although README is no regenerated, but it will be when merged and regenerated by bot), so I merge.

@pedrobaeza pedrobaeza merged commit 6ed59e4 into OCA:12.0 Dec 20, 2018
@pedrobaeza pedrobaeza deleted the 12.0-mig-email_template_qweb branch December 20, 2018 09:48
ernestotejeda pushed a commit to Tecnativa/social that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet