Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] mass_mailing_event #367

Closed
wants to merge 8 commits into from
Closed

[11.0][MIG] mass_mailing_event #367

wants to merge 8 commits into from

Conversation

thinkwelltwd
Copy link

No description provided.

@pedrobaeza
Copy link
Member

Is this still needed in v11?

@pedrobaeza pedrobaeza added this to the 11.0 milestone Mar 15, 2019
@thinkwelltwd
Copy link
Author

Well, it might not be; not fully familiar with v11 yet. I'm working at getting our company's v10 instance migrated and we're using it in v10, and it's on the list of modules to migrate in #203, so I did the PR.

@pedrobaeza
Copy link
Member

OK, please check it, as I'm not 100% sure, but it can be, as now at least you can use event.registration in mass mailing, but not sure about the specific features.

In a month, we will finish OpenUpgrade v12, so maybe it's interesting to consider migrating directly to v12 for your company.

@thinkwelltwd
Copy link
Author

In a month, we will finish OpenUpgrade v12, so maybe it's interesting to consider migrating directly to v12 for your company.

That is good news! 👍 I was hoping that it would be possible to jump to v12 so we don't have to train our staff on 2 version changes.

I'll keep working on v11 and v12 modules that we need, but plan to do the full migration when OpenUpgrade v12 is ready.

@pedrobaeza
Copy link
Member

This name overlaps with Odoo one: https://github.com/odoo/odoo/tree/11.0/addons/mass_mailing_event

@rafaelbn rafaelbn self-assigned this Oct 8, 2019
@rafaelbn
Copy link
Member

rafaelbn commented Oct 8, 2019

Yes this is needed in v11 and v12 and v13, but I Odoo has created a module with the same name (not same functionality) then we should change the name

@rafaelbn
Copy link
Member

rafaelbn commented Oct 8, 2019

Hi @thinkwelltwd , thanks for this migration. @chienandalu and me @rafaelbn are going to review this PR to have this merged asap :-D

@pedrobaeza pedrobaeza mentioned this pull request Jul 8, 2020
Closed
26 tasks
@rafaelbn
Copy link
Member

rafaelbn commented Jul 8, 2020

Hello @thinkwelltwd

This is embarrassing, sorry.

Could you check travis? It says:

2020-07-08 12:42:47,928 8047 INFO openerp_test extract_msg.message: Header found, but "cc" is not included. Will be generated from other streams.
2020-07-08 12:42:47,931 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: ERROR
2020-07-08 12:42:47,931 8047 INFO openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: test_msg_no_notification (odoo.addons.mail_drop_target.tests.test_mail_drop_target.TestMailDropTarget)
2020-07-08 12:42:48,100 8047 INFO openerp_test extract_msg.message: Stream "_recip_version1.0#00000000/__substg1.0_39FE001F" was requested but could not be found. Returning None.
2020-07-08 12:42:48,100 8047 INFO openerp_test extract_msg.message: Header found, but "cc" is not included. Will be generated from other streams.
2020-07-08 12:42:48,102 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: ERROR
2020-07-08 12:42:48,102 8047 INFO openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: test_no_msgextract (odoo.addons.mail_drop_target.tests.test_mail_drop_target.TestMailDropTarget)
2020-07-08 12:42:48,177 8047 INFO openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: ======================================================================
2020-07-08 12:42:48,177 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: ERROR: test_msg (odoo.addons.mail_drop_target.tests.test_mail_drop_target.TestMailDropTarget)
2020-07-08 12:42:48,177 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: Traceback (most recent call last):
2020-07-08 12:42:48,177 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: File "/home/travis/build/OCA/social/mail_drop_target/tests/test_mail_drop_target.py", line 37, in test_msg 2020-07-08 12:42:48,177 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: self.partner._name, message, thread_id=self.partner.id)
2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: File "/home/travis/build/OCA/social/mail_drop_target/models/mail_thread.py", line 62, in message_process_msg 2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: message_id=message_msg.message_id,
2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: AttributeError: 'Message' object has no attribute 'message_id' 2020-07-08 12:42:48,178 8047 INFO openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: ====================================================================== 2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: ERROR: test_msg_no_notification (odoo.addons.mail_drop_target.tests.test_mail_drop_target.TestMailDropTarget) 2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: Traceback (most recent call last): 2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: File "/home/travis/build/OCA/social/mail_drop_target/tests/test_mail_drop_target.py", line 65, in test_msg_no_notification
2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: self.partner._name, message, thread_id=self.partner.id) 2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: File "/home/travis/build/OCA/social/mail_drop_target/models/mail_thread.py", line 62, in message_process_msg
2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: message_id=message_msg.message_id, 2020-07-08 12:42:48,178 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: AttributeError: 'Message' object has no attribute 'message_id'
2020-07-08 12:42:48,179 8047 INFO openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: Ran 4 tests in 0.639s
2020-07-08 12:42:48,179 8047 ERROR openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: FAILED
2020-07-08 12:42:48,179 8047 INFO openerp_test odoo.addons.mail_drop_target.tests.test_mail_drop_target: (errors=2)
2020-07-08 12:42:48,179 8047 ERROR openerp_test odoo.modules.module: Module mail_drop_target: 0 failures, 2 errors
2020-07-08 12:42:48,503 8047 INFO openerp_test odoo.modules.registry: module mail_optional_autofollow: creating or updating database tables

@yajo @chienandalu please take care of this PR please

@pedrobaeza
Copy link
Member

This module name collides with the new core module that was introduced in v11.

@rafaelbn
Copy link
Member

rafaelbn commented Jul 8, 2020

@thinkwelltwd could you please rename to mass_mailing_event_registration_exclude

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn Awaiting requested review from rafaelbn

@chienandalu chienandalu Awaiting requested review from chienandalu

Assignees

@rafaelbn rafaelbn

Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@thinkwelltwd @pedrobaeza @rafaelbn @antespi @oca-transbot @chienandalu @yajo @oca-travis