Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12.0 mig mail_full_expand #387

Merged
merged 4 commits into from
May 23, 2019
Merged

12.0 mig mail_full_expand #387

merged 4 commits into from
May 23, 2019

Conversation

ernestotejeda
Copy link
Member

  • Adapt js
  • Adapt template
  • Readme by fragments

Cc @Tecnativa

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 22, 2019
pedrobaeza
pedrobaeza requested changes May 22, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash also commit history as shown in the other PR.

mail_full_expand/__manifest__.py Outdated Show resolved Hide resolved
@pedrobaeza pedrobaeza requested a review from yajo May 22, 2019 22:07
@ernestotejeda
Copy link
Member Author

Changes done

@pedrobaeza
Copy link
Member

The "[MIG] Rename manifest files" has not been squashed with 10.0 migration commit

yajo
yajo approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK

@yajo yajo requested a review from pedrobaeza May 23, 2019 07:14
pedrobaeza
pedrobaeza approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made myself the squashing for speeding up the merge.

@pedrobaeza pedrobaeza merged commit ef9be31 into OCA:12.0 May 23, 2019
@pedrobaeza pedrobaeza deleted the 12.0-mig-mail_full_expand branch May 23, 2019 07:26
@OCA-git-bot OCA-git-bot mentioned this pull request May 23, 2019
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ernestotejeda @pedrobaeza @yajo @OCA-git-bot @bouvyd @oca-transbot