Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] mass_mailing_list_dynamic: Migration to 12.0 #399

Merged
merged 8 commits into from
Aug 16, 2019
Merged

[MIG] mass_mailing_list_dynamic: Migration to 12.0 #399

merged 8 commits into from
Aug 16, 2019

Conversation

victormmtorres
Copy link

No description provided.

@victormmtorres victormmtorres force-pushed the 12.0-mig-mass_mailing_list_dynamic branch from 82a82af to 75f5647 Compare June 27, 2019 14:41
@victormmtorres victormmtorres marked this pull request as ready for review June 27, 2019 14:42
@victormmtorres
Copy link
Author

@Tardo Changes done

@victormmtorres victormmtorres force-pushed the 12.0-mig-mass_mailing_list_dynamic branch from 75f5647 to e207140 Compare June 28, 2019 11:28
@victormmtorres
Copy link
Author

I did pushed force again

ernestotejeda
ernestotejeda reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@ernestotejeda ernestotejeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on the Sync now button an error is thrown. Could you check that?

mass_mailing_list_dynamic/models/mail_mass_mailing_contact.py Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/models/mail_mass_mailing_list.py Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/readme/CONTRIBUTORS.rst Show resolved Hide resolved
mass_mailing_list_dynamic/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/readme/USAGE.rst Outdated Show resolved Hide resolved
chienandalu
chienandalu suggested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @victormmtorres Some comments below:

mass_mailing_list_dynamic/wizards/mail_mass_mailing_load_filter.py Show resolved Hide resolved
mass_mailing_list_dynamic/views/mail_mass_mailing_list_view.xml Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/readme/CONTRIBUTORS.rst Show resolved Hide resolved
mass_mailing_list_dynamic/README.rst Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/models/mail_mass_mailing_contact.py Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/models/mail_mass_mailing_contact.py Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/models/mail_mass_mailing_contact.py Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/views/mail_mass_mailing_list_view.xml Outdated Show resolved Hide resolved
mass_mailing_list_dynamic/models/mail_mass_mailing_list.py Outdated Show resolved Hide resolved
@victormmtorres victormmtorres force-pushed the 12.0-mig-mass_mailing_list_dynamic branch from e207140 to bdd3b87 Compare July 2, 2019 10:45
@victormmtorres
Copy link
Author

Changes done @ernestotejeda @chienandalu

ernestotejeda
ernestotejeda suggested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@ernestotejeda ernestotejeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some comments and I have made a PR suggesting some changes (Tecnativa#2). Please take a look

@victormmtorres
Copy link
Author

I have made some comments and I have made a PR suggesting some changes (Tecnativa#2). Please take a look

Hi @ernestotejeda could you push your commits directly to my branch? Here would be more efficient than compare and I extract what you expect

@ernestotejeda
Copy link
Member

@victormmtorres I pushed the Commit here on your branch and I have included what @pedrobaeza suggessted in this comment #399 (comment)

@rafaelbn rafaelbn requested a review from yajo July 12, 2019 19:05
@victormmtorres victormmtorres force-pushed the 12.0-mig-mass_mailing_list_dynamic branch 2 times, most recently from 8c7f547 to d22702a Compare July 22, 2019 11:53
@victormmtorres
Copy link
Author

@yajo please review

@victormmtorres victormmtorres force-pushed the 12.0-mig-mass_mailing_list_dynamic branch from d22702a to 0559e54 Compare July 23, 2019 09:24
@victormmtorres
Copy link
Author

@yajo changes done

@victormmtorres
Copy link
Author

@chienandalu Please review

@yajo yajo requested a review from chienandalu August 12, 2019 06:30
@yajo
Copy link
Member

yajo commented Aug 12, 2019

@victormmtorres you still have pending reviews from @Tardo and @ernestotejeda. Please attend their comments. Thanks!

@pedrobaeza
Copy link
Member

@yajo better that you take this as @victormmtorres is now with other things

oca-transbot and others added 6 commits August 16, 2019 12:15
@oca-transbot
OCA Transbot updated translations from Transifex
dc5941b
@pedrobaeza
[FIX+IMP] mass_mailing_list_dynamic: tests, icons, filters... (OCA#211)
fb76420 
* [FIX+IMP] mass_mailing_list_dynamic: tests, icons, filters...

* Brand new icon
* Added feature of loading an existing filter as criteria
* Tests as SavepointCase for optimizing times
* Tests in post-install for avoiding errors on res.partner not null constraints
  when several modules added them.
* Updated documentation.
* Fix mock in test for not commiting test data.

* [FIX] mass_mailing_list_dynamic: Wasn't able to create contacts in fully synced lists

Syncing context was being set in the wrong object. Added to test too.

* [FIX] mass_mailing_list_dynamic: Allow to write back vals from res.partner

Module mass_mailing_partner writes back certain values from partner to
mass_mailing_contact. Module should allow that write operation.
@chienandalu
[FIX] mass_mailing_list_dynamic: Reversible dynamic list
3edb0ec
@chienandalu
[IMP] mass_mailing_list_dynamic: make user aware of list change
e42d134 
- Adds is_synced field to track whether a dynamic list has unsynced
changes or not so the user is aware that the definitive number of
contacts is yet to be determined.
- It fixes an issue that made impossible deleting a res.partner filter
when a list had use it to filter contacts.
- It also shows only the filters available for the user (shared and
belonging to self).
@oca-travis
[UPD] Update mass_mailing_list_dynamic.pot
654b88f
[MIG] mass_mailing_list_dynamic: Migration to 12.0
1776230
@victormmtorres victormmtorres force-pushed the 12.0-mig-mass_mailing_list_dynamic branch from 0559e54 to 2777d6f Compare August 16, 2019 10:15
@victormmtorres
Copy link
Author

@yajo Changes done

@victormmtorres victormmtorres force-pushed the 12.0-mig-mass_mailing_list_dynamic branch from 2777d6f to b9eeff7 Compare August 16, 2019 14:03
@victormmtorres
Copy link
Author

@Tardo changes done

@rafaelbn rafaelbn added this to the 12.0 milestone Aug 16, 2019
Tardo
Tardo approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Rebased to 12.0-ocabot-merge-pr-399-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 16, 2019
Closed
24 tasks
OCA-git-bot added a commit that referenced this pull request Aug 16, 2019
@OCA-git-bot
Merge PR #399 into 12.0
1da0313 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit b9eeff7 into OCA:12.0 Aug 16, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1da0313. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@ernestotejeda ernestotejeda ernestotejeda requested changes

@Tardo Tardo Tardo approved these changes

@yajo yajo yajo approved these changes

@chienandalu chienandalu Awaiting requested review from chienandalu

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@victormmtorres @ernestotejeda @yajo @pedrobaeza @OCA-git-bot @Tardo @chienandalu @rafaelbn @oca-transbot @oca-travis