9.0 - email template qweb #57
Conversation
|
👍 No problem with the renaming |
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-tools/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback | ||
| `here <https://github.com/OCA/server-tools/issues/new?body=module:%20email_template_qweb%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. |
There was a problem hiding this comment.
it's hard to see between the url escape codes, but there's version: 8.0
|
a few remarks, 👍 after they're addressed. I also think it's a good idea to keep the name, but for the record: When renaming a module, please also file a PR against the relevant version of https://github.com/OCA/OpenUpgrade/blob/8.0/openerp/addons/openupgrade_records/lib/apriori.py - it's also helpful for people who don't use OpenUpgrade to have a comprehensive resource of OCA module renames. |
|
Good to know about the OpenUpgrade module rename file, thanks for the elaboration there. |
|
Comments addressed, thanks for the review @hbrunn |
|
now it's a question of time: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#please-respect-a-few-basic-rules |
|
I'm definitely new to this community, and any/all advice is most certainly welcome! Thanks for the link - I'm going to give the whole contributing doc a reread now that I have been lurking for a bit. |
|
👍 ready for merging. |
This PR brings
email_template_qwebto 9.0.One note is that there is now a naming discrepancy between Odoo and this module, as Odoo now refers to
emailas simplymail. I changed the names inside the module, but the module itself no longer corresponds. Probably negligible, but worth mentioning nonetheless.