Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Add mail_optional_follower_notification module #60

Merged
merged 5 commits into from
May 25, 2016
Merged

[ADD] Add mail_optional_follower_notification module #60

merged 5 commits into from
May 25, 2016

Conversation

adrienpeiffer
Copy link
Contributor

This module adds the possibility to choose if you want to automatically notify followers on mail.compose.message.

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-optional-follower-notifications-ape branch from c9bb91f to 5cbbe98 Compare May 18, 2016 10:43
@adrienpeiffer
Copy link
Contributor Author

Pending during investigation on #61

@hbrunn
Copy link
Member

hbrunn commented May 19, 2016

travis should be fixed after merging upstream, right?

hbrunn
hbrunn reviewed May 19, 2016
View reviewed changes
mail_optional_follower_notifications/README.rst
====================================

This module adds the possibility to choose if you want to automatically
notify followers on mail.compose.message.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write a sentence what the standard behavoir is

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-optional-follower-notifications-ape branch from 6978bb4 to 2d35fe8 Compare May 20, 2016 09:57
@adrienpeiffer
Copy link
Contributor Author

Rebased

@adrienpeiffer
Copy link
Contributor Author

Great ! Travis is happy 😄

@hbrunn hbrunn added this to the 8.0 milestone May 21, 2016
pedrobaeza
pedrobaeza reviewed May 21, 2016
View reviewed changes
mail_optional_follower_notifications/README.rst
Mail optional follower notifications
====================================


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove here extra lines

@pedrobaeza
Copy link
Member

For following the singular in module name convention, please rename it to mail_optional_follower_notification.

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-optional-follower-notifications-ape branch from 9b6996d to 58de968 Compare May 23, 2016 11:34
@adrienpeiffer
Copy link
Contributor Author

Thanks for the review @pedrobaeza !

@adrienpeiffer adrienpeiffer changed the title [ADD] Add mail_optional_follower_notifications module [ADD] Add mail_optional_follower_notification module May 23, 2016
@coveralls
Copy link

coveralls commented May 23, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 82.026% when pulling 58de968 on acsone:8.0-add-optional-follower-notifications-ape into b3bca2f on OCA:8.0.

@lmignon
Copy link
Sponsor Contributor

lmignon commented May 25, 2016

👍 (Code review + functional tests)

@hbrunn hbrunn merged commit 06e13cc into OCA:8.0 May 25, 2016
lmignon pushed a commit to acsone/social that referenced this pull request Jun 13, 2016
@adrienpeiffer @lmignon
[ADD] Add mail_optional_follower_notification module (OCA#60)
22f4fe0 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
adrienpeiffer added a commit to acsone/social that referenced this pull request Oct 24, 2016
@adrienpeiffer
Add mail_optional_follower_notification module (OCA#60)
70f8d15 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
lmignon pushed a commit to acsone/social that referenced this pull request Feb 13, 2017
@adrienpeiffer @lmignon
[ADD] Add mail_optional_follower_notification module (OCA#60)
b7bd5ac 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
SimoRubi pushed a commit to SimoRubi/social that referenced this pull request Oct 10, 2019
@sbidoul
Merge pull request OCA#60 from acsone/universal-newlines-sbi
9ff0413 
Call external tools with universal_newlines=True
lmignon pushed a commit to acsone/social that referenced this pull request Dec 6, 2019
@adrienpeiffer @lmignon
Add mail_optional_follower_notification module (OCA#60)
b1bd8d7 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
misern2 pushed a commit to QubiQ/social that referenced this pull request Mar 6, 2020
@adrienpeiffer @misern2
Add mail_optional_follower_notification module (OCA#60)
b3fb698 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
lmignon pushed a commit to acsone/social that referenced this pull request Nov 6, 2020
@adrienpeiffer @lmignon
Add mail_optional_follower_notification module (OCA#60)
ff29b1b 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
lmignon pushed a commit to acsone/social that referenced this pull request Nov 6, 2020
@adrienpeiffer @lmignon
Add mail_optional_follower_notification module (OCA#60)
870826d 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
denris pushed a commit to denris/social that referenced this pull request Jan 28, 2021
@adrienpeiffer
Add mail_optional_follower_notification module (OCA#60)
87e5b71 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
ioans73 pushed a commit to Studio73/social that referenced this pull request May 7, 2021
@adrienpeiffer @ioans73
Add mail_optional_follower_notification module (OCA#60)
77013bc 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
sbejaoui pushed a commit to acsone/social that referenced this pull request Jul 9, 2021
@adrienpeiffer @sbejaoui
Add mail_optional_follower_notification module (OCA#60)
573d83f 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
ioans73 pushed a commit to Studio73/social that referenced this pull request Aug 4, 2021
@adrienpeiffer @ioans73
Add mail_optional_follower_notification module (OCA#60)
0ff6f29 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
olgamarcocb pushed a commit to tegin/social that referenced this pull request Jan 21, 2022
@adrienpeiffer @olgamarcocb
Add mail_optional_follower_notification module (OCA#60)
cf4847d 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
olgamarcocb pushed a commit to tegin/social that referenced this pull request Jan 21, 2022
@adrienpeiffer @olgamarcocb
Add mail_optional_follower_notification module (OCA#60)
b89d02f 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
cvinh pushed a commit to cvinh/social that referenced this pull request Feb 28, 2022
@adrienpeiffer @cvinh
Add mail_optional_follower_notification module (OCA#60)
b4ca0ef 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
cvinh pushed a commit to cvinh/social that referenced this pull request Feb 28, 2022
@adrienpeiffer @cvinh
Add mail_optional_follower_notification module (OCA#60)
05c6a1a 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
robin5210 pushed a commit to robin5210/social that referenced this pull request Mar 9, 2022
@adrienpeiffer @robin5210
Add mail_optional_follower_notification module (OCA#60)
df16371 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
yankinmax pushed a commit to yankinmax/social that referenced this pull request Feb 17, 2023
@adrienpeiffer @yankinmax
Add mail_optional_follower_notification module (OCA#60)
ca996db 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
beagle-cloud pushed a commit to DynAppsNV/social that referenced this pull request Feb 9, 2024
@adrienpeiffer
Add mail_optional_follower_notification module (OCA#60)
962bdca 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
jdidderen-nsi pushed a commit to jdidderen-nsi/social that referenced this pull request Jun 4, 2024
@adrienpeiffer @jdidderen-nsi
Add mail_optional_follower_notification module (OCA#60)
0d3760d 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adrienpeiffer @hbrunn @pedrobaeza @coveralls @lmignon