[MIG][9.0] mail_attach_existing_attachment: Module migrated #68

sergio-teruel · 2016-06-08T23:03:50Z

pedrobaeza · 2016-06-08T23:35:34Z

mail_attach_existing_attachment/__openerp__.py

@@ -29,7 +29,7 @@
    'author': "ACSONE SA/NV,Odoo Community Association (OCA)",


Add Tecnativa here

pedrobaeza · 2016-06-08T23:38:16Z

You can put a better icon for this module

sergio-teruel · 2016-06-09T00:37:56Z

@pedrobaeza changes done

elicoidal · 2016-06-09T01:51:03Z

mail_attach_existing_attachment/README.rst

@@ -44,7 +44,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/social/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed feedback


you can simplify this part following latest README template

sergio-teruel · 2016-06-10T17:19:40Z

@pedrobaeza @elicoidal Changes done

pedrobaeza · 2016-06-10T17:47:00Z

mail_attach_existing_attachment/wizard/mail_compose_message.py

+    def get_mail_values(self, res_ids):
+        res = super(MailComposeMessage, self).get_mail_values(res_ids)
+        if self.object_attachment_ids.ids and self.model and len(res_ids) == 1:
+            if not res[res_ids[0]].get('attachment_ids'):


You can make res_id = res_ids[0] for clarifying the code

I'm thinking that you can simplify whole expression with:

res[res_ids[0]].setdefault('attachment_ids', []).extend(self.object_attachment_ids.ids)

pedrobaeza · 2016-06-10T18:12:55Z

There's only one line without coverage. As is a corner case, you can put # pragma: nocover for ignoring it in the coverage.

rafaelbn · 2016-06-10T19:45:25Z

Tested functionally with SO an INV 👍

pedrobaeza · 2016-06-11T09:20:52Z

mail_attach_existing_attachment/wizard/mail_compose_message.py

@@ -35,7 +35,7 @@ def default_get(self, fields_list):
        if res.get('res_id') and res.get('model') and \
                res.get('composition_mode', '') != 'mass_mail' and\
                not res.get('can_attach_attachment'):
-            # pragma: nocoverlo
+            # pragma: nocover


In the same line:

res['can_attach_attachment'] = True # pragma: nocover

Ouch now by my part. It's # pragma: no cover

coveralls · 2016-06-11T16:26:26Z

Coverage decreased (-2.9%) to 97.059% when pulling dff1b4f on Tecnativa:9.0-MIG-mail_attach_existing_attachment into aac3be7 on OCA:9.0.

coveralls · 2016-06-11T16:43:10Z

Coverage remained the same at 100.0% when pulling cbbdc24 on Tecnativa:9.0-MIG-mail_attach_existing_attachment into aac3be7 on OCA:9.0.

lasley · 2016-06-11T17:14:43Z

👍 code + tested on partner in Runbot

rafaelbn · 2016-06-11T22:08:53Z

@sergio-teruel review comments from @pedrobaeza and we can merge

pedrobaeza · 2016-06-12T23:53:51Z

👍

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

[MIG][9.0] mail_attach_existing_attachment: Module migrated

ed28e75

pedrobaeza reviewed Jun 8, 2016
View reviewed changes

[MIG][9.0] mail_attach_existing_attachment: Module migrated

bf44732

elicoidal reviewed Jun 9, 2016
View reviewed changes

[MIG][9.0] mail_attach_existing_attachment: Fix template and loop

bf5c034

pedrobaeza reviewed Jun 10, 2016
View reviewed changes

rafaelbn added the needs review label Jun 10, 2016

rafaelbn modified the milestones: 8.0, 9.0 Jun 10, 2016

pedrobaeza reviewed Jun 11, 2016
View reviewed changes

[MIG][9.0] mail_attach_existing_attachment: Fix coveralls

cbbdc24

sergio-teruel force-pushed the 9.0-MIG-mail_attach_existing_attachment branch from 5e5f164 to cbbdc24 Compare June 11, 2016 16:39

pedrobaeza mentioned this pull request Jun 12, 2016

Migration to version 9.0 #20

Closed

31 tasks

pedrobaeza merged commit dc8996e into OCA:9.0 Jun 12, 2016

pedrobaeza deleted the 9.0-MIG-mail_attach_existing_attachment branch June 12, 2016 23:54

ernestotejeda pushed a commit to ernestotejeda/social that referenced this pull request Apr 17, 2018

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

796f2fe

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

hbrunn pushed a commit that referenced this pull request Jun 13, 2018

[MIG][9.0] mail_attach_existing_attachment: Module migrated (#68)

1850047

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

ghost pushed a commit to camptocamp/social that referenced this pull request Aug 21, 2018

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

3c20d25

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

ernestotejeda pushed a commit to Tecnativa/social that referenced this pull request Nov 5, 2018

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

e91e7fd

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

pedrobaeza pushed a commit to Tecnativa/social that referenced this pull request Dec 5, 2018

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

937ea45

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

AdriaGForgeFlow pushed a commit to ForgeFlow/social that referenced this pull request Dec 21, 2018

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

bcd680d

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

alan196 pushed a commit to Jarsa/social that referenced this pull request Dec 22, 2018

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

ca19bce

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

ernestotejeda pushed a commit to Tecnativa/social that referenced this pull request Mar 7, 2019

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

8a8a775

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

manuelcalerosolis pushed a commit to Tecnativa/social that referenced this pull request Mar 3, 2020

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

8683edf

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

Rad0van pushed a commit to Rad0van/social that referenced this pull request Aug 24, 2020

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

e15a92b

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

denris pushed a commit to denris/social that referenced this pull request Jan 28, 2021

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

4730877

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

ernestotejeda pushed a commit to Tecnativa/social that referenced this pull request Jul 21, 2021

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

1aa1fd3

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

AlvaroTForgeFlow pushed a commit to ForgeFlow/social that referenced this pull request Dec 9, 2021

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

8056012

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

baimont pushed a commit to acsone/social that referenced this pull request Aug 29, 2022

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

976acd1

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

baimont pushed a commit to acsone/social that referenced this pull request Oct 3, 2022

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

1167734

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

baimont pushed a commit to acsone/social that referenced this pull request Jan 19, 2023

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

3db0d8a

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

astirpe pushed a commit to astirpe/social that referenced this pull request Feb 3, 2024

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

b1e74ab

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

astirpe pushed a commit to astirpe/social that referenced this pull request May 5, 2024

[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)

c707140

* [MIG][9.0] mail_attach_existing_attachment: Module migrated

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][9.0] mail_attach_existing_attachment: Module migrated #68

[MIG][9.0] mail_attach_existing_attachment: Module migrated #68

sergio-teruel commented Jun 8, 2016

pedrobaeza Jun 8, 2016

pedrobaeza commented Jun 8, 2016

sergio-teruel commented Jun 9, 2016

elicoidal Jun 9, 2016

sergio-teruel commented Jun 10, 2016

pedrobaeza Jun 10, 2016

pedrobaeza Jun 10, 2016

pedrobaeza commented Jun 10, 2016

rafaelbn commented Jun 10, 2016

pedrobaeza Jun 11, 2016

sergio-teruel Jun 11, 2016

pedrobaeza Jun 11, 2016 •

edited

Loading

coveralls commented Jun 11, 2016 •

edited

Loading

coveralls commented Jun 11, 2016 •

edited

Loading

lasley commented Jun 11, 2016

rafaelbn commented Jun 11, 2016

pedrobaeza commented Jun 12, 2016

		@@ -29,7 +29,7 @@
		'author': "ACSONE SA/NV,Odoo Community Association (OCA)",

[MIG][9.0] mail_attach_existing_attachment: Module migrated #68

[MIG][9.0] mail_attach_existing_attachment: Module migrated #68

Conversation

sergio-teruel commented Jun 8, 2016

pedrobaeza Jun 8, 2016

Choose a reason for hiding this comment

pedrobaeza commented Jun 8, 2016

sergio-teruel commented Jun 9, 2016

elicoidal Jun 9, 2016

Choose a reason for hiding this comment

sergio-teruel commented Jun 10, 2016

pedrobaeza Jun 10, 2016

Choose a reason for hiding this comment

pedrobaeza Jun 10, 2016

Choose a reason for hiding this comment

pedrobaeza commented Jun 10, 2016

rafaelbn commented Jun 10, 2016

pedrobaeza Jun 11, 2016

Choose a reason for hiding this comment

sergio-teruel Jun 11, 2016

Choose a reason for hiding this comment

pedrobaeza Jun 11, 2016 • edited Loading

Choose a reason for hiding this comment

coveralls commented Jun 11, 2016 • edited Loading

coveralls commented Jun 11, 2016 • edited Loading

lasley commented Jun 11, 2016

rafaelbn commented Jun 11, 2016

pedrobaeza commented Jun 12, 2016

pedrobaeza Jun 11, 2016 •

edited

Loading

coveralls commented Jun 11, 2016 •

edited

Loading

coveralls commented Jun 11, 2016 •

edited

Loading