Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] mail_restrict_send_button (Issue #768) #769

Merged
merged 1 commit into from Sep 10, 2021
Merged

[14.0][FIX] mail_restrict_send_button (Issue #768) #769

merged 1 commit into from Sep 10, 2021

Conversation

patrickrwilson
Copy link

This is the fix for issue #768 that presented itself after an Odoo core update.

@patrickrwilson
[FIX] Issue OCA#768
20fd94d 
This is the fix for issue OCA#768

[FIX] Pre-Commit
@patrickrwilson
Copy link
Author

@pedrobaeza @osi-scampbell @max3903 @dreispt Can you assist with reviewing and merging? Thanks in advance.

smangukiya
smangukiya approved these changes Sep 10, 2021
View reviewed changes
Copy link

@smangukiya smangukiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good for testing.

Don't you think this will stop attachment loading immediately?

@patrickrwilson
Copy link
Author

@smangukiya attachments still seem to work during my testing so I think we are still good.

@patrickrwilson
Copy link
Author

@OCA/social-maintainers Hello everyone, is there anyone who can help merge this PR?

bodedra
bodedra approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

@dreispt
Copy link
Sponsor Member

dreispt commented Sep 10, 2021

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-769-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 269a3df into OCA:14.0 Sep 10, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c8472d9. Thanks a lot for contributing to OCA. ❤️

@dreispt dreispt mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smangukiya smangukiya smangukiya approved these changes

@bodedra bodedra bodedra approved these changes

@osi-scampbell osi-scampbell osi-scampbell approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patrickrwilson @dreispt @OCA-git-bot @smangukiya @bodedra @osi-scampbell