-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] mail_signature_multilang #8
Conversation
@@ -0,0 +1,79 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't include standard SVG file if there's no modification over the template
You should propose this as a patch to Odoo for at least master branch (but I think it can also be in v9 as it doesn't require any DB layout change). Ask @antespi for how to do it. Thinking twice about the name, maybe mail_signature_translatable can be a more proper technical name. |
I have tested and work fine. A user will send the signature in the language she/he is using. |
@JavierIniesta @antespi have you proposed to Odoo this module as a Patch? |
Let's wait for the Odoo answer about the patch (it can land in core v8 because it doesn't impact on DB layout, or if not, on OCB) before merging this, but you need to make the patch. |
Odoo patch propused: odoo/odoo#8329 |
it works 👍 |
Answer from Odoo:
|
I don't think Odoo will include this in v8, IMO we can merge 👍 |
And what about OCB? |
Please @antespi make a PR to OCA like in odoo/odoo#8329 Last answer from Odoo is: "I will update the usability team with your suggestion for the improvement." |
PR to OCA done in OCA/OCB#330 |
This addon sets translatable the signature field.