Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] mail_signature_multilang #8

Closed
wants to merge 3 commits into from

Conversation

JavierIniesta
Copy link

This addon sets translatable the signature field.

@@ -0,0 +1,79 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include standard SVG file if there's no modification over the template

@pedrobaeza
Copy link
Member

You should propose this as a patch to Odoo for at least master branch (but I think it can also be in v9 as it doesn't require any DB layout change). Ask @antespi for how to do it.

Thinking twice about the name, maybe mail_signature_translatable can be a more proper technical name.

@rafaelbn
Copy link
Member

I have tested and work fine. A user will send the signature in the language she/he is using.
👍

@rafaelbn
Copy link
Member

rafaelbn commented Sep 1, 2015

@JavierIniesta @antespi have you proposed to Odoo this module as a Patch?
@pedrobaeza IMO this module work correct and can be merged. If added this functionality to v9 we will deprecate it

@pedrobaeza
Copy link
Member

Let's wait for the Odoo answer about the patch (it can land in core v8 because it doesn't impact on DB layout, or if not, on OCB) before merging this, but you need to make the patch.

@antespi
Copy link
Contributor

antespi commented Sep 2, 2015

Odoo patch propused: odoo/odoo#8329

@janetrp
Copy link

janetrp commented Sep 2, 2015

it works 👍

@rafaelbn
Copy link
Member

rafaelbn commented Sep 4, 2015

Answer from Odoo:

I really appreciate your suggestion. could you mail us to feedback@odoo.com ?

@rafaelbn
Copy link
Member

rafaelbn commented Sep 4, 2015

I don't think Odoo will include this in v8, IMO we can merge 👍

@pedrobaeza
Copy link
Member

And what about OCB?

@rafaelbn
Copy link
Member

rafaelbn commented Sep 7, 2015

Please @antespi make a PR to OCA like in odoo/odoo#8329

Last answer from Odoo is: "I will update the usability team with your suggestion for the improvement."

@JavierIniesta
Copy link
Author

PR to OCA done in OCA/OCB#330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants