Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_barcodes_gs1_expiry #237

Merged
merged 5 commits into from Jan 14, 2020
Merged

[12.0][MIG] stock_barcodes_gs1_expiry #237

merged 5 commits into from Jan 14, 2020

Conversation

JoanSForgeFlow
Copy link

Standard stock_barcodes_gs1_expiry migration to v12.

Depends on #235 and #236.

cc ~ @ForgeFlow @LoisRForgeFlow

@JoanSForgeFlow JoanSForgeFlow force-pushed the 12.0-mig-stock_barcodes_gs1_expiry branch from a0d7ab2 to a854bb5 Compare December 23, 2019 09:02
@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 23, 2019
@JoanSForgeFlow JoanSForgeFlow force-pushed the 12.0-mig-stock_barcodes_gs1_expiry branch from a854bb5 to 8663351 Compare January 9, 2020 12:10
@JoanSForgeFlow JoanSForgeFlow force-pushed the 12.0-mig-stock_barcodes_gs1_expiry branch from 8663351 to 6c40a44 Compare January 9, 2020 12:11
LoisRForgeFlow
LoisRForgeFlow approved these changes Jan 13, 2020
View reviewed changes
Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM.

You can add yourself as a contributor!

sergio-teruel
sergio-teruel approved these changes Jan 13, 2020
View reviewed changes
Copy link

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only generate the readme file again

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-237-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 13, 2020
@OCA-git-bot
Merge PR #237 into 12.0
d6e2c68 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 6c40a44 into OCA:12.0 Jan 14, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3227c5a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JoanSForgeFlow @OCA-git-bot @pedrobaeza @sergio-teruel @LoisRForgeFlow @oca-travis