Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] barcodes_generator_product: Migration to 14.0 #314

Closed

Conversation

chafique-delli
Copy link

Depends on the PR: #313

legalsylvain and others added 21 commits December 11, 2020 17:54
* Rename manifest
* Change openerp references to odoo
* Bump version
* Fix spelling errors and add product avatar to icon
* Remove product_barcode_generator
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-11.0/stock-logistics-barcode-11.0-barcodes_generator_product
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-11-0/stock-logistics-barcode-11-0-barcodes_generator_product/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_product
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_product/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_product
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_product/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_product
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_product/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_product
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_product/
Currently translated at 76.5% (13 of 17 strings)

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_product
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_product/it/
@chafique-delli chafique-delli force-pushed the 14.0-mig-barcodes_generator_product branch from 2b02608 to a2a2140 Compare December 14, 2020 18:54
@chafique-delli chafique-delli mentioned this pull request Jan 4, 2021
15 tasks
@alexis-via alexis-via force-pushed the 14.0-mig-barcodes_generator_product branch from 6af0cfd to a2a2140 Compare January 22, 2021 16:28
Copy link

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix selection _GENERATE_TYPE


from odoo import api, fields, models

from odoo.addons.barcodes_generator_abstract.models.barcode_rule import _GENERATE_TYPE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from odoo.addons.barcodes_generator_abstract.models.barcode_rule import _GENERATE_TYPE

Same as d7806ed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, here does not apply because it's a diferent module

Comment on lines +30 to +31
selection=_GENERATE_TYPE,
readonly=True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
selection=_GENERATE_TYPE,
readonly=True,

Same as d7806ed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done at #357

@hugho-ad
Copy link
Contributor

@chafique-delli do you continue with this?

@hugho-ad
Copy link
Contributor

superbased by
#357

@oca-clabot
Copy link

Hey @chafique-delli,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet