Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_barcodes #469

Merged
merged 80 commits into from
Dec 14, 2022
Merged

Conversation

LoisRForgeFlow
Copy link

Migration to v15.

@ForgeFlow

cc @sergio-teruel @etobella

sergio-teruel and others added 30 commits November 29, 2022 16:46
When user creates a lot, set default product the wizard selected product.
When confirm the lot creation wizard, set this lot in lot wizard scanning barcode field.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-11.0/stock-logistics-barcode-11.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-11-0/stock-logistics-barcode-11-0-stock_barcodes/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
When we've got an out picking, the logical workflow is that the scanned location
is the location we're getting the stock from
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-13.0/stock-logistics-barcode-13.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-13-0/stock-logistics-barcode-13-0-stock_barcodes/
UID = 1 is sometimes called "System" and sometimes "OdooBot", depending on the
installed set of modules, so tests can fail if you rely on this data.

Removing that variable from the tests, we get resilient tests.
Followup of dab52c9. There's another test that hardcodes OdooBot name for uid=1.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-13.0/stock-logistics-barcode-13.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-13-0/stock-logistics-barcode-13-0-stock_barcodes/
LoisRForgeFlow and others added 10 commits November 29, 2022 16:46
In pickings, the scan log was always generated without details of
the move lines modified/created. Without this information in the log
removing the log was dong nothing else than just that, removing the
log; leaving the last operation still reflected in the picking.

Also, when the picking was a draft one, the stock move line and
the stock move could have been created by the scan itself, so we
need to remove it in that case, reverting the action would leave
the stock move there that could be validated by mistake.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-14.0/stock-logistics-barcode-14.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-14-0/stock-logistics-barcode-14-0-stock_barcodes/
@LoisRForgeFlow LoisRForgeFlow added this to the 15.0 milestone Nov 29, 2022
@sergio-teruel
Copy link

Thanks @LoisRForgeFlow I will take a look ASAP!!

@sebalix
Copy link

sebalix commented Dec 1, 2022

/ocabot migration stock_barcodes

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 1, 2022
14 tasks
Copy link

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok

@LoisRForgeFlow
Copy link
Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-469-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7f22b80 into OCA:15.0 Dec 14, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 55f8481. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-mig-stock_barcodes branch December 14, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet