Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] stock_location_orderpoint_cleanup #17

Open
wants to merge 8 commits into
base: 16.0
Choose a base branch
from
Open

[ADD] stock_location_orderpoint_cleanup #17

wants to merge 8 commits into from

Conversation

rousseldenis
Copy link
Sponsor Contributor

No description provided.

@rousseldenis rousseldenis force-pushed the 16.0-add-stock-location-orderpoint-purge-dro branch 2 times, most recently from ae6b488 to 79dc7fb Compare May 22, 2024 12:59
jbaudoux
jbaudoux approved these changes May 22, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @mt-software-de

@rousseldenis rousseldenis marked this pull request as ready for review May 22, 2024 13:05
@rousseldenis
Copy link
Sponsor Contributor Author

@FrancoMaxime ready :-)

@rousseldenis rousseldenis force-pushed the 16.0-add-stock-location-orderpoint-purge-dro branch from 79dc7fb to 0d0e92c Compare May 22, 2024 13:10
@FrancoMaxime
Copy link
Member

FrancoMaxime commented May 22, 2024 •
edited
Loading

@rousseldenis Thanks Denis, Nice PR :).

Just a little question, why are the dates not standardized in the copyright section?

mt-software-de
mt-software-de suggested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this PR helps a lot. :-)
Minor remarks.

stock_location_orderpoint_cleanup/models/stock_location_orderpoint.py Outdated Show resolved Hide resolved
stock_location_orderpoint_cleanup/models/stock_location_orderpoint.py Show resolved Hide resolved
stock_location_orderpoint_cleanup/models/stock_location_orderpoint.py Show resolved Hide resolved
stock_location_orderpoint_cleanup/models/stock_location_orderpoint.py Show resolved Hide resolved
stock_location_orderpoint_cleanup/security/security.xml Outdated Show resolved Hide resolved
stock_location_orderpoint_cleanup/views/stock_location_orderpoint.xml Show resolved Hide resolved
stock_location_orderpoint_cleanup/wizards/stock_location_orderpoint_cleanup.py Outdated Show resolved Hide resolved
stock_location_orderpoint_cleanup/wizards/stock_location_orderpoint_cleanup.xml Outdated Show resolved Hide resolved
@rousseldenis
Copy link
Sponsor Contributor Author

I think this is ready

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

lmignon
lmignon approved these changes May 28, 2024
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM (Code review)

@rousseldenis
Copy link
Sponsor Contributor Author

@rousseldenis Thanks Denis, Nice PR :).

Just a little question, why are the dates not standardized in the copyright section?

Because I need to update my mrbob config :-)

gurneyalex
gurneyalex approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall ok with the addon. I have a small doubt over the naming though. I thought at first it would be about cleaning up orderpoints, and not stock moves.

Maybe to be clarified either in the technical name or in the displayed name of the module.

@rousseldenis
Copy link
Sponsor Contributor Author

rousseldenis commented Jul 8, 2024 •
edited
Loading

Overall ok with the addon. I have a small doubt over the naming though. I thought at first it would be about cleaning up orderpoints, and not stock moves.

Maybe to be clarified either in the technical name or in the displayed name of the module.

@gurneyalex I think the README is clear enough 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoMaxime FrancoMaxime FrancoMaxime left review comments

@lmignon lmignon lmignon approved these changes

@gurneyalex gurneyalex gurneyalex approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@mt-software-de mt-software-de mt-software-de approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rousseldenis @FrancoMaxime @OCA-git-bot @lmignon @gurneyalex @jbaudoux @mt-software-de