Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_quantity_history_location: Migration to version 15.0 #272

Merged

Conversation

ernestotejeda
Copy link
Member

@ernestotejeda ernestotejeda commented Mar 29, 2023

Supersede #202

  • Inherit the template to change the button name
  • Modify action["display_name"] instead of action["name"]
  • Add attrs="{'invisible': [('location_id', '=', False)]}" to the 'Include child locations' field in its XML view definition
  • Squash administrative commits to reduce the commit history

Cc @Tecnativa TT37324

ping @pedrobaeza @chienandalu @desdelinux @rousseldenis

JordiBForgeFlow and others added 18 commits March 29, 2023 13:30
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-reporting-13.0/stock-logistics-reporting-13.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-13-0/stock-logistics-reporting-13-0-stock_quantity_history_location/ro/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-reporting-13.0/stock-logistics-reporting-13.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-13-0/stock-logistics-reporting-13-0-stock_quantity_history_location/it/
…rors according to stock_account_quantity_history_location
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_quantity_history_location/ja/
<?xml version="1.0" encoding="UTF-8" ?>
<templates>
<t t-extend="StockInventoryReport.Buttons">
<t t-jquery="button.o_button_at_date" t-operation="inner">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only must change the button description if we have group_stock_multi_locations security group.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only little comment

@pedrobaeza
Copy link
Member

/ocabot migration stock_quantity_history_location

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 29, 2023
13 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#167) has been updated to reference the current pull request.
however, a previous pull request was referenced : #196.
Perhaps you should check that there is no duplicate work.
CC : @annadurai-sodexis

Co-authored-by: DavidJForgeFlow <david.jimenez@forgeflow.com>
@ernestotejeda ernestotejeda force-pushed the 15.0-mig-stock_quantity_history_location branch from e382125 to 45e9880 Compare March 29, 2023 21:23
@ernestotejeda
Copy link
Member Author

changes done @sergio-teruel

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-272-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b580b22 into OCA:15.0 Mar 29, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 287e517. Thanks a lot for contributing to OCA. ❤️

@desdelinux
Copy link

Hello @ernestotejeda , are you going to migrate this to 16.0?

@chienandalu
Copy link
Member

Not soon @desdelinux . Feel free to do it 😄 (it shouldn't be much effort I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet