[16.0][MIG] stock_quantity_history_location: Migration to 16.0 #275
Conversation
… on Account Valuation
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-reporting-13.0/stock-logistics-reporting-13.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-13-0/stock-logistics-reporting-13-0-stock_quantity_history_location/ro/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-reporting-13.0/stock-logistics-reporting-13.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-13-0/stock-logistics-reporting-13-0-stock_quantity_history_location/it/
… re-use by othher addons
…rors according to stock_account_quantity_history_location
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_quantity_history_location/ja/
Co-authored-by: DavidJForgeFlow <david.jimenez@forgeflow.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_quantity_history_location/
slitheryduke11
force-pushed
the
16.0-mig-stock_quantity_history_location
branch
4 times, most recently
from
e776675
to
4b42306
Compare
|
Hi @luisg123v, @JordiBForgeFlow, @ernestotejeda . I think the migration of this module to 16.0 is ready. I would appreciate it if you could help me with the review. Thanks in advance! |
|
/ocabot migration stock_quantity_history_location |
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 15.0\n" |
There was a problem hiding this comment.
16.0.
Please regenerate the template file
There was a problem hiding this comment.
@luisg123v FYI the pot file is regenerated at merge and usually is not required to be changed on PR's
There was a problem hiding this comment.
@rousseldenis thanks for pointing it out. I was aware .po files were regenerated, but I didn't know about .pot files also were, I though .po were regenerated from the provided .pot.
Then this LGTM.
There was a problem hiding this comment.
The .pot is regenerated at merge (of any kind) as if some code has been modified, pot file should be synced with current code. po files are only modified by weblate modifications (several timea per day).
|
/ocabot merge nobump |
|
Sorry @luisg123v you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
It seems I can't merge here. Could you help me running the merge command, please? Regards, |
|
This PR has the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
Indeed, as you have to be already a maintainer of the module to have merge rights. |
slitheryduke11
force-pushed
the
16.0-mig-stock_quantity_history_location
branch
from
4b42306
to
81275f1
Compare
|
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-275-by-rousseldenis-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Hi, @rousseldenis. I've updated the maintainers list to give it a line-by-line format. |
😅 maybe unnecessary if pre-commit does not warn |
|
@rousseldenis could you re-run the merge command, please? |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c13047c. Thanks a lot for contributing to OCA. ❤️ |
The group attribute is added to the 'include_child_locations' field because the module could not be installed otherwise.
Also, a conditional that is never reached is removed because the model's native method always returns a dictionary, making the conditional unnecessary.